Page MenuHomeSolus

MySQL C++ bindings for T4281. Dependency for MySQL Workbench, allowing completion of T243.
AbandonedPublic

Authored by herbmillerjr on Sep 2 2017, 9:16 PM.

Details

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
herbmillerjr created this revision.Sep 2 2017, 9:16 PM
JoshStrobl requested changes to this revision.Sep 13 2017, 10:00 AM
JoshStrobl added a subscriber: JoshStrobl.

Make sure to update the MySQL workbench patch to indicate it depends on this.

package.yml
7

It's GPL-2.0, which is SPDX-compliant.

8

This should be programming.library.

14

Use pkgconfigs, which should also be listed before explicit builddep package names.

pspec_x86_64.xml
23–25

You need to fix your prefixing. /usr isn't a valid patch for these. They should go into a doc folder, like /usr/share/doc/mysql-connector-cpp/

40

You need to disable static libraries.

This revision now requires changes to proceed.Sep 13 2017, 10:00 AM
herbmillerjr edited edge metadata.
herbmillerjr marked 5 inline comments as done.

Made Josh's requested corrections.
License is SPDX formatted
Moved to programming.library component
Changed mariad to pkgconfig, boost didn't have one
Corrected documentation and static library issues

JoshStrobl requested changes to this revision.Oct 9 2017, 11:09 AM

Sorry for the delayed response. Here's one last thing that needs to be sorted.

package.yml
2

Name should be mysql-connector-cpp given we're not adding ++ in repo names or package names anymore.

This revision now requires changes to proceed.Oct 9 2017, 11:09 AM
JoshStrobl abandoned this revision.Nov 9 2017, 5:42 PM

Abandoning due to lack of movement.

herbmillerjr updated this revision to Diff 3617.EditedNov 25 2017, 4:27 PM
herbmillerjr edited edge metadata.

Change package name from c++ to cpp.

My apologies as well for my delay. Got distracted by other things.

pspec_x86_64.xml
23–25

This is actually build tree stuff that the mysql-related projects love leaking into the install root. Other distros remove them so I'm just going to do the same.

40

Doesn't look like they added this to the cmake variables for this project. Other distros seem to just strip out the one static library that is made, so I did the same.

Bit late to the party here bud. Work is happening on D1401.

Bit late to the party here bud. Work is happening on D1401.

My mistake. I'll defer to that one moving forward.

herbmillerjr abandoned this revision.Nov 25 2017, 5:47 PM