Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T243: MySQL Workbench
T4281: mysql-connector-c++
Diff Detail
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Make sure to update the MySQL workbench patch to indicate it depends on this.
| package.yml | ||
|---|---|---|
| 7 | It's GPL-2.0, which is SPDX-compliant. | |
| 8 | This should be programming.library. | |
| 14 | Use pkgconfigs, which should also be listed before explicit builddep package names. | |
| pspec_x86_64.xml | ||
| 23–25 | You need to fix your prefixing. /usr isn't a valid patch for these. They should go into a doc folder, like /usr/share/doc/mysql-connector-cpp/ | |
| 40 | You need to disable static libraries. | |
Made Josh's requested corrections.
License is SPDX formatted
Moved to programming.library component
Changed mariad to pkgconfig, boost didn't have one
Corrected documentation and static library issues
Sorry for the delayed response. Here's one last thing that needs to be sorted.
| package.yml | ||
|---|---|---|
| 2 | Name should be mysql-connector-cpp given we're not adding ++ in repo names or package names anymore. | |
My apologies as well for my delay. Got distracted by other things.
| pspec_x86_64.xml | ||
|---|---|---|
| 23–25 | This is actually build tree stuff that the mysql-related projects love leaking into the install root. Other distros remove them so I'm just going to do the same. | |
| 40 | Doesn't look like they added this to the cmake variables for this project. Other distros seem to just strip out the one static library that is made, so I did the same. | |