Page MenuHomeSolus

Patch Arcanist to check XDG config dirs for existing configs
ClosedPublic

Authored by serebit on Sun, Aug 2, 4:34 AM.

Details

Summary

I attempted to get this behavior upstreamed, but the devs didn't want additional complexity. With this patch, the default behavior of Arcanist does not change, but the tool will properly detect a pre-existing config file at ~/.config/arcrc or $XDG_CONFIG_DIR/arcrc, just like Git's approach to XDG Base Directory Specification compliance. This allows perfect backwards compatibility, while adding flexibility for those who don't wish to have cluttered home directories.

Test Plan

Submit this patch with a config file in ~/.config/arcrc

Diff Detail

Repository
R375 arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Sun, Aug 2, 4:34 AM
serebit requested review of this revision.Sun, Aug 2, 4:34 AM
serebit edited the summary of this revision. (Show Details)Sun, Aug 2, 4:34 AM
serebit edited the test plan for this revision. (Show Details)
JoshStrobl accepted this revision.Sun, Aug 2, 12:08 PM
JoshStrobl added a subscriber: JoshStrobl.

Ah yes...the added complexity of like..15 lines. But they'll go ahead and have no issues implementing a bunch of crap like Conpherence (when vastly superior chat systems exist) and Phortune for accounts and billing. Yea...okay. They're welcome to explain that flawless logic to me.

Patch looks great.

This revision is now accepted and ready to land.Sun, Aug 2, 12:08 PM