Paths

Table of Contentst

Differential D9347

Remove python2 support for python-pbkdf2
ClosedPublic
Actions

Authored by algent on Jul 31 2020, 9:38 PM.

Tags

None

Referenced Files

	F11047654: D9347.diff
	Thu, Aug 10, 3:42 PM

	F11020364: D9347.diff
	Mon, Aug 7, 4:13 AM

	F11013815: D9347.diff
	Fri, Aug 4, 5:39 PM

	F10938657: D9347.id.diff
	Thu, Jul 13, 4:51 PM

	F10852726: D9347.id22536.diff
	Jun 13 2023, 4:05 AM

	F10849083: D9347.id22610.diff
	Jun 11 2023, 6:20 PM

	F10846404: D9347.id22630.diff
	Jun 11 2023, 4:37 AM

	F10845533: D9347.id22534.diff
	Jun 11 2023, 12:49 AM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2640:de0190659f11: Remove python2 support for python-pbkdf2

Summary

This package is required only by electrum which is built with python3.

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Run electrum and check wallet.
Run example:

>>> from pbkdf2 import crypt
>>> crypt("secret")
'$p5k2$$fJXmQUFV$P8Ame5C6UICUUoE/div12KfsSBsIcf7a'
>>> crypt("secret", "XXXXXXXX")
'$p5k2$$XXXXXXXX$L9mVVdq7upotdvtGvXTDTez3FIu3z0uG'
>>> crypt("secret", "XXXXXXXX", 400)  # 400 iterations (the default for crypt)
'$p5k2$$XXXXXXXX$L9mVVdq7upotdvtGvXTDTez3FIu3z0uG'
>>> crypt("spam", iterations=400)
'$p5k2$$KRViI6xT$iAVt/MstaC3z8PAg7WTm3skd6vKuphIB'
>>> crypt("spam", iterations=1000)    # 1000 iterations
'$p5k2$3e8$ymj2XjKg$iBVfVzm696MdFtRdYzfR3fVvL96kSQ/P'

Diff Detail

Repository

R2640 python-pbkdf2

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

algent created this revision.Jul 31 2020, 9:38 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 31 2020, 9:38 PM

algent requested review of this revision.Jul 31 2020, 9:38 PM

algent edited the test plan for this revision. (Show Details)Jul 31 2020, 9:43 PM

A better summary

JoshStrobl requested changes to this revision.Aug 5 2020, 3:39 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
9	That isn't really better. It was fine the way it was.

This revision now requires changes to proceed.Aug 5 2020, 3:39 PM

Make summary as it was.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 6 2020, 4:01 PM

Closed by commit R2640:de0190659f11: Remove python2 support for python-pbkdf2 (authored by algent, committed by JoshStrobl). · Explain WhyAug 6 2020, 4:02 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R2640:de0190659f11: Remove python2 support for python-pbkdf2.

Revision Contents
Changeset List

Path

Size

13 lines

pspec_x86_64.xml

19 lines

Diff 22630

package.yml

Loading...

pspec_x86_64.xml

Loading...