Page MenuHomeSolus

Initial inclusion of libgnt for pidgin / finch
Needs ReviewPublic

Authored by TClark77 on Thu, Jul 30, 9:21 PM.

Details

Reviewers
ermo
JoshStrobl
Group Reviewers
Triage Team
Summary

Initial inclusion of libgnt for pidgin / finch
Changelog available here

Test Plan
  • Built local packages and installed. Re-built pidin & finch, installed local builds.
  • Launched pidgin. Verified it connected to an account.
  • Launched finch. Verified it connected to an account.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

TClark77 requested review of this revision.Thu, Jul 30, 9:21 PM
TClark77 created this revision.
ermo added a subscriber: ermo.Thu, Jul 30, 9:28 PM
ermo added inline comments.
package.yml
27

If this is necessary in certain scenarios, there should be a comment explaining why.

If it's no longer necessary, it should be removed.

ermo requested changes to this revision.Thu, Jul 30, 9:31 PM
This revision now requires changes to proceed.Thu, Jul 30, 9:31 PM
TClark77 updated this revision to Diff 22516.Thu, Jul 30, 10:38 PM
TClark77 marked an inline comment as done.

Updated package.yml to keep docs

JoshStrobl requested changes to this revision.Fri, Jul 31, 10:35 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

Cosmetic change, builddeps should be alphabetized:

- pkgconfig(glib-2.0)
- pkgconfig(gtk-doc)
- pkgconfig(libxml-2.0)
- pkgconfig(ncursesw)
- pkgconfig(python3)
This revision now requires changes to proceed.Fri, Jul 31, 10:35 AM
TClark77 updated this revision to Diff 22551.Sun, Aug 2, 5:33 PM

Alphabetized builddeps