Page MenuHomeSolus

Summary: Update pidgin-sipe from 1.23.2 to 1.25.0
AbandonedPublic

Authored by TClark77 on Jul 26 2020, 9:00 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Changelog available here

Issue T9149
Test Plan
  • Installed the plugin in pidin. Verified it is configurable in the UI.
  • Added an account, verified it tried to connect

Diff Detail

Repository
R2432 pidgin-sipe
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

TClark77 requested review of this revision.Jul 26 2020, 9:00 PM
TClark77 created this revision.
JoshStrobl requested changes to this revision.Jul 31 2020, 10:48 AM
JoshStrobl added a subscriber: JoshStrobl.

Does it no longer use farstream or the gstreamer bits? What does it say during configure time during build?

This revision now requires changes to proceed.Jul 31 2020, 10:48 AM
TClark77 added a comment.EditedAug 2 2020, 6:10 PM

Does it no longer use farstream or the gstreamer bits? What does it say during configure time during build?

According to their FAQ these two dependencies are still needed. After examining the make output in a little more detail I noticed that it's building against the older pidin-devel 2.13. I'm going to hold off on submitting this until pidgin 2.14 is merged to avoid duplicating effort on this plugin.

Extracting the files of gstreamer-1.0-plugins-base-devel
Installed gstreamer-1.0-plugins-base-devel                                                                           
Installing 86 / 86
libpurple-devel-2.13.0-25-1-x86_64.eopkg [cached]

I captured the make output in a log file, and there appear to be no problems with gstreamer or farstream during make at all. They were installed as expected. I'm not sure why they were removed from the file. I'll take a closer look at this after pidgin 2.14 merges.

algent added a subscriber: algent.EditedAug 2 2020, 7:10 PM

I noticed that it's building against the older pidin-devel 2.13. I'm going to hold off on submitting this until pidgin 2.14 is merged to avoid duplicating effort on this plugin.

No, just copy all eopkg files:

libpurple-2.14.1-26-1-x86_64.eopkg
libpurple-devel-2.14.1-26-1-x86_64.eopkg
pidgin-2.14.1-26-1-x86_64.eopkg
pidgin-devel-2.14.1-26-1-x86_64.eopkg

to local folder like you did with libgnt and do make local for pidgin-sipe.

Later add this package to the pidgin stack by adding in this summary Depends on D9304.

Don't forget git commit --amend si very important :D

I noticed that it's building against the older pidin-devel 2.13. I'm going to hold off on submitting this until pidgin 2.14 is merged to avoid duplicating effort on this plugin.

No, just copy all eopkg files:

Ah, thanks for the advice. I got it rebuild against pidgin 2.14 successfully. The abi_used_libs file still doesn't include the missing libraries. I'll have to look into this more tomorrow.

After looking into this with DataDrake, it looks like it's trying to build against pidgin-3 and failing dependencies when it sees pidgin 2. Holding off on updating this for now since there aren't any user complaints and the current version of the plugin is working.

JoshStrobl abandoned this revision.Aug 18 2020, 6:51 PM

Given said discussion, going to close this revision.