Page MenuHomeSolus

Updates nitrokey-app to v1.4.2
ClosedPublic

Authored by kaktuspalme on Jul 25 2020, 7:47 AM.
Tags
None
Referenced Files
F11072990: D9302.id22437.diff
Sat, Aug 12, 3:18 AM
F11072989: D9302.id24404.diff
Sat, Aug 12, 3:18 AM
F11072988: D9302.id23328.diff
Sat, Aug 12, 3:18 AM
F11072987: D9302.id.diff
Sat, Aug 12, 3:18 AM
F11072986: D9302.id23647.diff
Sat, Aug 12, 3:18 AM
F11072985: D9302.id22860.diff
Sat, Aug 12, 3:18 AM
F11054258: D9302.diff
Fri, Aug 11, 12:33 AM
F11000482: D9302.diff
Sat, Jul 29, 9:27 AM

Details

Summary

Changes from upstream (v1.4.0 and 1.4.2):

  • This release is focused on providing support for the Storage v0.54. Additionally it contains a couple of improvements, and translation updates.
  • Correct Bash completion dir installation path

Fixes T9117

Test Plan

I connected my nitrokey after installation and tried out totp and the password safe.

Diff Detail

Repository
R4518 nitrokey-app
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

There's an AppImage upstream, so if you don't want to add it to the repository again I would understand that.
I use the tool daily and noticed after todays update that it's not installed anymore, so I made a package for myself :)

JoshStrobl added a subscriber: JoshStrobl.

Your summary should be properly formatted, e.g. having Changelog in bold Markdown tags, changes as list items (with no prefixed whitespace before the list item symbol, -)

package.yml
10–11

You have a bunch of extra whitespace.

10–11

Should be listed after the Qt5 deps. Alphabetically it goes 0-9A-Za-z

This revision now requires changes to proceed.Aug 18 2020, 7:03 PM
  • Removed extra whitespaces
  • Sorted deps
kaktuspalme retitled this revision from Updates nitrokey-app to v1.4.1 to Updates nitrokey-app to v1.4.2.Sep 19 2020, 7:18 AM
kaktuspalme edited the summary of this revision. (Show Details)
package.yml
5

Just personal preference. Is the general policy to use tarballs when available? If so I will change that.

JoshStrobl added inline comments.
package.yml
5

You should be using tarballs when possible so we're not unnecessarily cloning git history.

This revision now requires changes to proceed.Sep 24 2020, 7:41 PM
This revision is now accepted and ready to land.Dec 16 2020, 9:48 AM
This revision was automatically updated to reflect the committed changes.