Page MenuHomeSolus

Updates nitrokey-app to v1.4.2
ClosedPublic

Authored by kaktuspalme on Jul 25 2020, 7:47 AM.

Details

Summary

Changes from upstream (v1.4.0 and 1.4.2):

  • This release is focused on providing support for the Storage v0.54. Additionally it contains a couple of improvements, and translation updates.
  • Correct Bash completion dir installation path

Fixes T9117

Test Plan

I connected my nitrokey after installation and tried out totp and the password safe.

Diff Detail

Repository
R4518 nitrokey-app
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktuspalme created this revision.Jul 25 2020, 7:47 AM
kaktuspalme requested review of this revision.Jul 25 2020, 7:47 AM

There's an AppImage upstream, so if you don't want to add it to the repository again I would understand that.
I use the tool daily and noticed after todays update that it's not installed anymore, so I made a package for myself :)

JoshStrobl requested changes to this revision.Aug 18 2020, 7:03 PM
JoshStrobl added a subscriber: JoshStrobl.

Your summary should be properly formatted, e.g. having Changelog in bold Markdown tags, changes as list items (with no prefixed whitespace before the list item symbol, -)

package.yml
10–11

You have a bunch of extra whitespace.

10–11

Should be listed after the Qt5 deps. Alphabetically it goes 0-9A-Za-z

This revision now requires changes to proceed.Aug 18 2020, 7:03 PM
kaktuspalme edited the summary of this revision. (Show Details)Aug 22 2020, 6:39 AM
  • Removed extra whitespaces
  • Sorted deps
kaktuspalme marked 2 inline comments as done.Sep 8 2020, 11:28 AM

Update to 1.4.2

kaktuspalme retitled this revision from Updates nitrokey-app to v1.4.1 to Updates nitrokey-app to v1.4.2.Sep 19 2020, 7:18 AM
kaktuspalme edited the summary of this revision. (Show Details)
kaktuspalme added inline comments.Sep 24 2020, 5:05 AM
package.yml
5

Just personal preference. Is the general policy to use tarballs when available? If so I will change that.

JoshStrobl requested changes to this revision.Sep 24 2020, 7:41 PM
JoshStrobl added inline comments.
package.yml
5

You should be using tarballs when possible so we're not unnecessarily cloning git history.

This revision now requires changes to proceed.Sep 24 2020, 7:41 PM

Changed to tar.gz

kaktuspalme marked 2 inline comments as done.Oct 13 2020, 4:47 PM
DataDrake accepted this revision.Dec 16 2020, 9:31 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

JoshStrobl accepted this revision.Dec 16 2020, 9:48 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 16 2020, 9:48 AM
This revision was automatically updated to reflect the committed changes.