Page MenuHomeSolus

Update audacity to 2.4.1
ClosedPublic

Authored by serebit on Jul 25 2020, 3:26 AM.

Details

Summary

Also assign myself as maintainer.

Notable changes in 2.4.0 (2.4.1 was a hotfix):

  • A new Time Toolbar showing current record/playback time
  • Presets for more effects can be imported and exported
  • Several new effects
  • Opus available as an export format
  • Multi-View mode for tracks

Full release notes for 2.4.0 are available here.

Test Plan

Open up I Want You by Savage Garden in FLAC format, and mess around with clip boundaries

Diff Detail

Repository
R403 audacity
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Jul 25 2020, 3:26 AM
serebit requested review of this revision.Jul 25 2020, 3:26 AM
serebit updated this revision to Diff 22436.Jul 25 2020, 3:42 AM

Fix email

serebit updated this revision to Diff 22463.Jul 27 2020, 11:29 PM

Remove patches, change build system to CMake

An additional note: Audacity 2.4.2 forces use of its own vendored fork of wxwidgets, and it doesn't do it in a way that makes any sense. There are commits to address this that haven't made it into a release yet, but we're likely to have to pull in their wxwidgets to get this to build in the future.

JoshStrobl requested changes to this revision.Jul 28 2020, 2:30 PM
JoshStrobl added a subscriber: JoshStrobl.

Given the amount of people that actually use it and provide patches for it, including several on Core Team + Global Maintainers, I'd appreciate if you could remove the MAINTAINERS.md file you added.

package.yml
42

%make_install -C build

This revision now requires changes to proceed.Jul 28 2020, 2:30 PM
serebit updated this revision to Diff 22491.Jul 28 2020, 5:07 PM

Address Josh's nagging complaints :P

JoshStrobl requested changes to this revision.Jul 30 2020, 9:28 AM
JoshStrobl added inline comments.
abi_used_libs
18

Is it not using id3tag anymore? Can you validate this by exporting an mp3, saving the file, then seeing if you get the Edit Metadata Tags window? And that the metadata you provided is actually saved during export.

19

This ABI removal should be looked into.

30

This ABI removal should be looked into.

package.yml
38

Is there a reason it is using its own version of lame now?

This revision now requires changes to proceed.Jul 30 2020, 9:28 AM
serebit added inline comments.Jul 30 2020, 5:12 PM
abi_used_libs
18

Validated that that works. Don't know why it isn't using the lib.

serebit added inline comments.Jul 30 2020, 5:14 PM
package.yml
38

For some reason, there's no longer an option to not statically link it AND not load it dynamically. It's one or the other.

serebit marked an inline comment as done.Jul 30 2020, 5:54 PM
serebit added inline comments.
abi_used_libs
19

Seems related to LV2 plugins, but to what end I'm not sure. It appears to have been statically linked originally, so if it's no longer bundled, my guess is it's just no longer needed. We'd likely have to ask the Audacity developers to be sure.

30

Also seems related to LV2 plugins, in this case for loading plugin GUIs. As with liblilv, not sure why this was removed, but it appears to have been statically linked.

JoshStrobl accepted this revision.Aug 5 2020, 5:15 PM

LGTM then, thanks!

This revision is now accepted and ready to land.Aug 5 2020, 5:15 PM
This revision was automatically updated to reflect the committed changes.