Page MenuHomeSolus

mupen64plus-qt
Needs ReviewPublic

Authored by ckorn on Tue, Jul 21, 5:56 PM.

Details

Reviewers
Girtablulu
Group Reviewers
Triage Team
Maniphest Tasks
T7398: Package Request: Mupen64Plus-Qt
Summary

The inclusion fixes T7398

Test Plan

The package builds, starts and works as far as can tell after a short test.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

ckorn created this revision.Tue, Jul 21, 5:56 PM
ckorn requested review of this revision.Tue, Jul 21, 5:56 PM
Girtablulu requested changes to this revision.Tue, Jul 21, 9:43 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
7
14

you should use the pkgconfig( ), you can find it via eopkg info qt5-base-devel

22

-Dm00755

23

not needed

24

-Dm00644

25

-Dm00644

This revision now requires changes to proceed.Tue, Jul 21, 9:44 PM
ckorn updated this revision to Diff 22377.Wed, Jul 22, 4:39 AM

Fixed the required issues

Fixes license
Uses pkgconfig
Removes LICENSE file
Fix install rights parameter