Paths

Table of Contentst

Differential D9272

Initial inclusion of mupen64plus-qt
ClosedPublic
Actions

Authored by ckorn on Jul 21 2020, 5:56 PM.

Tags

None

Referenced Files

	F11010589: D9272.id22377.diff
	Thu, Aug 3, 5:48 AM

	F10934844: D9272.id22837.diff
	Wed, Jul 12, 4:14 PM

	F10851646: D9272.id22377.diff
	Jun 12 2023, 3:04 PM

	F10849149: D9272.id22842.diff
	Jun 11 2023, 6:34 PM

	F10847141: D9272.id22837.diff
	Jun 11 2023, 9:11 AM

	F10844302: D9272.id22842.diff
	Jun 10 2023, 8:37 PM

	F10825617: D9272.diff
	Jun 4 2023, 12:41 AM

	F10779467: D9272.id.diff
	May 24 2023, 5:38 PM

View All 11 Files

Subscribers

Details

Reviewers

Girtablulu
JoshStrobl

Group Reviewers

Maniphest Tasks

T7398: Package Request: Mupen64Plus-Qt

Commits

R5064:c8b9ac7252f5: Initial inclusion of mupen64plus-qt

Summary

The inclusion fixes T7398

Test Plan

The package builds, starts and works as far as can tell after a short test.

Diff Detail

Repository

R5064 mupen64plus-qt

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ckorn created this revision.Jul 21 2020, 5:56 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 21 2020, 5:56 PM

ckorn requested review of this revision.Jul 21 2020, 5:56 PM

Girtablulu requested changes to this revision.Jul 21 2020, 9:43 PM

Girtablulu added a subscriber: Girtablulu.

Girtablulu added inline comments.

package.yml
7	SPDX confirm license https://spdx.org/licenses/preview/
14	you should use the pkgconfig( ), you can find it via `eopkg info qt5-base-devel`
22	-Dm00755
23	not needed
24	-Dm00644
25	-Dm00644

This revision now requires changes to proceed.Jul 21 2020, 9:44 PM

Fixed the required issues

Fixes license
Uses pkgconfig
Removes LICENSE file
Fix install rights parameter

Please additionally add a MAINTAINERS.md file (it doesn't need to be installed with the package), replacing the applicable content below:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME

package.yml
14	Should be above the explicitly named package (quazip-devel).
24	Could just be thrown in `/usr/share/pixmaps/`

JoshStrobl requested changes to this revision.Aug 18 2020, 7:08 PM

This revision now requires changes to proceed.Aug 18 2020, 7:08 PM

Fixed the issues

Added MAINTAINERS.md
Changed builddeps
Changed icon installation path.

ckorn marked 2 inline comments as done.Aug 19 2020, 4:44 AM

LGTM, thanks!

JoshStrobl retitled this revision from mupen64plus-qt to Initial inclusion of mupen64plus-qt.Aug 19 2020, 1:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2020, 1:39 PM

Closed by commit R5064:c8b9ac7252f5: Initial inclusion of mupen64plus-qt (authored by ckorn, committed by JoshStrobl). · Explain Why

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5064:c8b9ac7252f5: Initial inclusion of mupen64plus-qt.

Revision Contents
Changeset List

Path

Size

7 lines

1 line

10 lines

23 lines

pspec_x86_64.xml

36 lines

Diff 22842

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...