Differential D927

Initial commit of python-nbconvert
ClosedPublic
Actions

Authored by EP01 on Aug 31 2017, 4:34 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R3716:a8de0bfb8b20: Initial commit of python-nbconvert

Summary

Initial commit of nbconvert, a dependancy of Spyder (T1664).

Test Plan

Converted a dozen Jupyter notebooks to different formats.

Diff Detail

Repository

R3716 python-nbconvert

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

EP01 created this revision.Aug 31 2017, 4:34 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 31 2017, 4:34 PM

Update to 5.3.0. UTF-8 patch no longer required.

Update to 5.3.1

JoshStrobl added a subscriber: JoshStrobl.Sep 13 2017, 10:32 AM

JoshStrobl added inline comments.

package.yml
11	Why is networking needed?

Marking with request changes so I know from the stack list not to land it yet.

This revision now requires changes to proceed.Sep 13 2017, 10:38 AM

@JoshStrobl The setup file (see Line 69 onwards) downloads a CSS file from here to be used during installation. I tried to add the file as a source but was unable to get it in the right place to be recognised, so I ran with networking instead. Also, this downloaded file is MIT licensed, hence the extra MIT license field.