Page MenuHomeSolus
Differential D9252

Add iproute2 rundep
ClosedPublic
Actions

Authored by saintdev on Jul 18 2020, 9:13 PM.
Tags
None
Referenced Files
F11032922: D9252.id22510.diff
Wed, Aug 9, 2:55 PM
F11032921: D9252.id22441.diff
Wed, Aug 9, 2:55 PM
F11032920: D9252.id22440.diff
Wed, Aug 9, 2:55 PM
F11032919: D9252.id.diff
Wed, Aug 9, 2:55 PM
F11032918: D9252.id22338.diff
Wed, Aug 9, 2:55 PM
F11025946: D9252.diff
Wed, Aug 9, 1:35 AM
F11009644: D9252.id22510.diff
Wed, Aug 2, 6:03 PM
F11008441: D9252.diff
Wed, Aug 2, 3:27 AM
View All 29 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R5030:ed843d5602c7: Add iproute2 rundep
Summary
  • Add iproute2 as a rundep. wg-quick is a bash script that unconditionally depends on the ip command from iproute2
Test Plan

Tested WireGuard connection using wg-quick

Diff Detail

Repository
R5030 wireguard-tools
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

saintdev created this revision.Jul 18 2020, 9:13 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 18 2020, 9:13 PM
saintdev requested review of this revision.Jul 18 2020, 9:13 PM
saintdev retitled this revision from Add iproute2 rundep and install bash completions to Add iproute2 rundep and explicitly enable bash completions.Jul 18 2020, 9:15 PM
saintdev edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Jul 20 2020, 12:05 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
16

This isn't necessary, we already ship the bash completion files and by default it is YES.

This revision now requires changes to proceed.Jul 20 2020, 12:05 PM
saintdev updated this revision to Diff 22440.Jul 26 2020, 6:13 AM

Remove explicitly enabling bash completion

saintdev updated this revision to Diff 22441.Jul 26 2020, 6:15 AM
saintdev retitled this revision from Add iproute2 rundep and explicitly enable bash completions to Add iproute2 rundep.
saintdev edited the summary of this revision. (Show Details)
saintdev edited the test plan for this revision. (Show Details)

Update description

saintdev marked an inline comment as done.Jul 26 2020, 6:16 AM
JoshStrobl accepted this revision.Jul 30 2020, 1:01 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 30 2020, 1:01 PM
Closed by commit R5030:ed843d5602c7: Add iproute2 rundep (authored by saintdev, committed by JoshStrobl). · Explain WhyJul 30 2020, 1:02 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5030:ed843d5602c7: Add iproute2 rundep.

Revision Contents
Changeset List

PathSize
5 lines
12 lines

Diff 22338

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.