Page MenuHomeSolus

Add iproute2 rundep
ClosedPublic

Authored by saintdev on Jul 18 2020, 9:13 PM.

Details

Summary
  • Add iproute2 as a rundep. wg-quick is a bash script that unconditionally depends on the ip command from iproute2
Test Plan

Tested WireGuard connection using wg-quick

Diff Detail

Repository
R5030 wireguard-tools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

saintdev created this revision.Jul 18 2020, 9:13 PM
saintdev requested review of this revision.Jul 18 2020, 9:13 PM
saintdev retitled this revision from Add iproute2 rundep and install bash completions to Add iproute2 rundep and explicitly enable bash completions.Jul 18 2020, 9:15 PM
saintdev edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Jul 20 2020, 12:05 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
16

This isn't necessary, we already ship the bash completion files and by default it is YES.

This revision now requires changes to proceed.Jul 20 2020, 12:05 PM
saintdev updated this revision to Diff 22440.Jul 26 2020, 6:13 AM

Remove explicitly enabling bash completion

saintdev updated this revision to Diff 22441.Jul 26 2020, 6:15 AM
saintdev retitled this revision from Add iproute2 rundep and explicitly enable bash completions to Add iproute2 rundep.
saintdev edited the summary of this revision. (Show Details)
saintdev edited the test plan for this revision. (Show Details)

Update description

saintdev marked an inline comment as done.Jul 26 2020, 6:16 AM
JoshStrobl accepted this revision.Jul 30 2020, 1:01 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 30 2020, 1:01 PM
This revision was automatically updated to reflect the committed changes.