Page MenuHomeSolus

Update and replace Riot by Element 1.7.0
ClosedPublic

Authored by silke on Jul 15 2020, 5:07 PM.
Tags
None
Referenced Files
F11051703: D9241.id22328.diff
Thu, Aug 10, 8:13 PM
F11051702: D9241.id.diff
Thu, Aug 10, 8:13 PM
F11051701: D9241.id22326.diff
Thu, Aug 10, 8:13 PM
F11051700: D9241.id22309.diff
Thu, Aug 10, 8:13 PM
F11036173: D9241.diff
Wed, Aug 9, 7:03 PM
F11010736: D9241.diff
Thu, Aug 3, 7:49 AM
F11006635: D9241.diff
Tue, Aug 1, 4:17 PM
F10876883: D9241.diff
Jun 20 2023, 2:20 PM
Subscribers

Details

Summary

Rename riot to element and update to 1.7.0.

Rename announcement: https://element.io/blog/welcome-to-element/

Changelog: https://github.com/vector-im/riot-desktop/blob/develop/CHANGELOG.md

Test Plan
  • Start without local config
  • Start and send a few encrypted messages

Diff Detail

Repository
R2816 element
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

silke requested review of this revision.Jul 15 2020, 5:07 PM
JoshStrobl added a subscriber: JoshStrobl.

Looking at the list of changes from v1.7.0 to develop HEAD (here) it's my opinion that the rename and update on our part may be a bit premature and we should wait until a .1 is out that incorporates the various icon, hosting link, etc. changes.

Unlike the celluloid patch however, I'm not gonna make a fuss over the lack of a transition path for Riot users between the desktop files, executables, etc. This isn't part of the base install so it won't affect all users OOTB. Still an inconvenience for those that have it pinned / favorited depending on the desktop environment though.

Marking as Request Changes until a .1 is out.

This revision now requires changes to proceed.Jul 16 2020, 10:16 AM

Looking at the list of changes from v1.7.0 to develop HEAD (here) it's my opinion that the rename and update on our part may be a bit premature and we should wait until a .1 is out that incorporates the various icon, hosting link, etc. changes.

It's out now, and we no longer need that huge patch :)

Unlike the celluloid patch however, I'm not gonna make a fuss over the lack of a transition path for Riot users between the desktop files, executables, etc. This isn't part of the base install so it won't affect all users OOTB. Still an inconvenience for those that have it pinned / favorited depending on the desktop environment though.

I did take a (brief) look at this. The problem I encountered was that riot will be removed first, at which point the icon disappears. It didn't seem to return after a riot.desktop was installed from Element, so I left it out of my changes.

LGTM, thanks for the patch and replaces. Nice timing on their part for the .1 release.

This revision is now accepted and ready to land.Jul 17 2020, 6:38 AM
This revision was automatically updated to reflect the committed changes.