Differential D9235

Inclusion of GOverlay
ClosedPublic
Actions

Authored by Jacek on Jul 14 2020, 10:05 AM.

Tags

None

Referenced Files

	F11052488: D9235.id.diff
	Thu, Aug 10, 9:27 PM

	F11052487: D9235.id22264.diff
	Thu, Aug 10, 9:27 PM

	F11052486: D9235.id22278.diff
	Thu, Aug 10, 9:27 PM

	F11052485: D9235.id22315.diff
	Thu, Aug 10, 9:27 PM

	F11052484: D9235.id22263.diff
	Thu, Aug 10, 9:27 PM

	F11037113: D9235.diff
	Wed, Aug 9, 8:06 PM

	F11017567: D9235.id22264.diff
	Sun, Aug 6, 3:26 AM

	F10764234: D9235.id22278.diff
	May 19 2023, 6:08 AM

View All 15 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T9014: GOverlay, GUI for MangoHud and vkBasalt

Commits

R5040:c370e347f775: Inclusion of GOverlay

Summary

Fixes T9014. Depends on D8365, D9234.
This adds a friendly overlay for configuring MangoHud and vkBasalt.

Test Plan

Tested with in-progress vkBasalt and MangoHud taken from dev.getsol.us.
Used over a few days on OpenGL and Vulkan games on 2 PCs

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Jacek created this revision.Jul 14 2020, 10:05 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 14 2020, 10:05 AM

Removed leftover comment

JoshStrobl requested changes to this revision.Jul 14 2020, 10:46 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
13	Let's change this to pkgconfig(gtk+-2.0), gtk+-2.0 is more likely to be the one people will search for when it comes to rebuilds and the likes.
17	I'm guessing it needs glxinfo and probably not glxgears yea? IMO would probably just make more sense to move glxinfo into mesalib itself and just keep mesa-demos for glxgears (or even just have a package literally for glxgears via splitting).

This revision now requires changes to proceed.Jul 14 2020, 10:46 AM

Jacek added inline comments.Jul 14 2020, 11:58 AM

package.yml
17	Actually it needs glxgears and not glxinfo, because it uses that as the tests if OpenGL overlay work. And it uses vkcube as a test for Vulkan overlay.

Switch pkgconfig of gtk-2-devel

Jacek marked 2 inline comments as done.Jul 14 2020, 12:04 PM

LGTM, thanks!

package.yml
17	Weird. Can't say I was expecting that.

This revision is now accepted and ready to land.Jul 14 2020, 12:10 PM

Closed by commit R5040:c370e347f775: Inclusion of GOverlay (authored by Jacek, committed by JoshStrobl). · Explain WhyJul 16 2020, 9:53 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5040:c370e347f775: Inclusion of GOverlay.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

13 lines

23 lines

pspec_x86_64.xml

40 lines

Diff 22263

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...