Page MenuHomeSolus

Inclusion of GOverlay
ClosedPublic

Authored by Jacek on Jul 14 2020, 10:05 AM.

Details

Summary

Fixes T9014. Depends on D8365, D9234.
This adds a friendly overlay for configuring MangoHud and vkBasalt.

Test Plan

Tested with in-progress vkBasalt and MangoHud taken from dev.getsol.us.
Used over a few days on OpenGL and Vulkan games on 2 PCs

Diff Detail

Repository
R5040 goverlay
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacek created this revision.Jul 14 2020, 10:05 AM
Jacek requested review of this revision.Jul 14 2020, 10:05 AM
Jacek updated this revision to Diff 22264.

Removed leftover comment

JoshStrobl requested changes to this revision.Jul 14 2020, 10:46 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

Let's change this to pkgconfig(gtk+-2.0), gtk+-2.0 is more likely to be the one people will search for when it comes to rebuilds and the likes.

17

I'm guessing it needs glxinfo and probably not glxgears yea? IMO would probably just make more sense to move glxinfo into mesalib itself and just keep mesa-demos for glxgears (or even just have a package literally for glxgears via splitting).

This revision now requires changes to proceed.Jul 14 2020, 10:46 AM
Jacek added inline comments.Jul 14 2020, 11:58 AM
package.yml
17

Actually it needs glxgears and not glxinfo, because it uses that as the tests if OpenGL overlay work. And it uses vkcube as a test for Vulkan overlay.

Jacek updated this revision to Diff 22278.Jul 14 2020, 12:03 PM

Switch pkgconfig of gtk-2-devel

Jacek marked 2 inline comments as done.Jul 14 2020, 12:04 PM
JoshStrobl accepted this revision.Jul 14 2020, 12:10 PM

LGTM, thanks!

package.yml
17

Weird. Can't say I was expecting that.

This revision is now accepted and ready to land.Jul 14 2020, 12:10 PM
This revision was automatically updated to reflect the committed changes.