Page MenuHomeSolus
Differential D9234

Inclusion of vkBasalt
ClosedPublic
Actions

Authored by Jacek on Jul 14 2020, 9:24 AM.
Tags
None
Referenced Files
F11052494: D9234.id22314.diff
Thu, Aug 10, 9:27 PM
F11052493: D9234.id.diff
Thu, Aug 10, 9:27 PM
F11052492: D9234.id22261.diff
Thu, Aug 10, 9:27 PM
F11052491: D9234.id22262.diff
Thu, Aug 10, 9:27 PM
F11052490: D9234.id22312.diff
Thu, Aug 10, 9:27 PM
F11052489: D9234.id22279.diff
Thu, Aug 10, 9:27 PM
F11037116: D9234.diff
Wed, Aug 9, 8:06 PM
F11022913: D9234.diff
Tue, Aug 8, 6:37 AM
View All 25 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8508: vkBasalt
Commits
R5039:12763def16b8: Inclusion of vkBasalt
Summary

Fixes T8508. This should provide a Vulkan-only post processing layer akin to Reshade.
This is used best with a GOverlay - a GUI that help you configure it in a much easier way.

Test Plan

Configure it using GOverlay.
Test CAS, FXAA and SMAA in a few different DXVK games on Intel and Nvidia GPU.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Jacek created this revision.Jul 14 2020, 9:24 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 14 2020, 9:24 AM
Jacek requested review of this revision.Jul 14 2020, 9:24 AM
Jacek updated this revision to Diff 22262.Jul 14 2020, 9:33 AM

Fix the MAINTAINERS.md

Jacek added a child revision: D9235: Inclusion of GOverlay.Jul 14 2020, 10:05 AM
JoshStrobl requested changes to this revision.Jul 14 2020, 10:43 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
12

Yeaaa ew. I'd much rather this be condensed into a single line, e.g. Currently, the built-in effects are: Contrast Adaptive Sharpening, Denoised Luma... etc.

23

Your indentation is off here.

26

pkgconfig should always be above strictly named ones.

This revision now requires changes to proceed.Jul 14 2020, 10:43 AM
Jacek updated this revision to Diff 22279.Jul 14 2020, 12:09 PM

Description and cosmetic changes to package.yml

Jacek marked 3 inline comments as done.Jul 14 2020, 12:10 PM
JoshStrobl requested changes to this revision.Jul 15 2020, 7:21 AM
JoshStrobl added inline comments.
package.yml
12

Still some necessary newlining. It could basically just be:

description: |
    vkBasalt is a Vulkan post processing layer to enhance the visual graphics of games. Currently, the build in effects are: Contrast Adaptive Sharpening, Denoised Luma Sharpening, Fast Approximate Anti-Aliasing, Enhanced Subpixel Morphological Anti-Aliasing, 3D color LookUp Table. It is also possible to use Reshade Fx shaders and it can be easily configured using GOverlay.
This revision now requires changes to proceed.Jul 15 2020, 7:21 AM
Jacek updated this revision to Diff 22312.Jul 15 2020, 9:21 PM

Changed the description to please IDoS

Jacek marked an inline comment as done.Jul 15 2020, 9:22 PM
JoshStrobl accepted this revision.Jul 16 2020, 9:36 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 16 2020, 9:36 AM
Closed by commit R5039:12763def16b8: Inclusion of vkBasalt (authored by Jacek, committed by JoshStrobl). · Explain WhyJul 16 2020, 9:48 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5039:12763def16b8: Inclusion of vkBasalt.

Revision Contents
Changeset List

PathSize
6 lines
1 line
386 lines
386 lines
5 lines
5 lines
31 lines
52 lines

Diff 22261

View Options

MAINTAINERS.md

Loading...
View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_symbols32

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_libs32

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.