Changed the build system to CMake and Ninja.
Link to Changelog here.
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Commits
- R1697:5abf46942035: Update gd to 2.3.0
Rebuilt libgphoto against it and run these commands
pngtogd in.png out.gd && gdtopng out.gd eg1.png && eog eg1.png pngtogd2 in.png out.gd2 1024 1 && gd2topng out.gd2 eg2.png && eog eg2.png
with full success.
Diff Detail
Diff Detail
- Repository
- R1697 gd
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| package.yml | ||
|---|---|---|
| 33 | This should not be necessary unless they're not respecting DCMAKE_LIB_SUFFIX. | |
Comment Actions
I'll submit patches to their GitHub repo so the next version will have a better CMake build.
| package.yml | ||
|---|---|---|
| 33 | DCMAKE_LIB_SUFFIX wasn't respected so this should stay as it is. | |
| package.yml | ||
|---|---|---|
| 25 | Without looking at their CMakeLists.txt file, it isn't immediately clear what this does. Can we replace this with a patch? | |
Comment Actions
Otherwise LGTM. Thank you for the patch instead of the sed, makes it much easier to figure out the intent :)
| pspec_x86_64.xml | ||
|---|---|---|
| 36 | INSTALL, README* can be nuked. | |