Update crow-translate to 2.4.1
ClosedPublic
Actions

Authored by algent on Jul 6 2020, 7:41 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R4905:9ff136175b07: Update crow-translate to 2.4.1

Summary

Changelog:

Added
- --brief option to print only translations.
- The ability to add, remove or reorder used languages.
- Swap languages shortcut.

Changed
- Use https instead of http for all engines.
- --audio-only option now only plays text.
- Automatic translation disabled by default.
- Fix duplicated default swap shortcut.
- Improve global shortcuts error logging.

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Installed locally and translate a few sentences.
Check translations with Google, Yandex and Bing.
Translate using cli and keyboard shortcut
Use text speaking, in different languages.

Diff Detail

Repository

R4905 crow-translate

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

algent created this revision.Jul 6 2020, 7:41 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 6 2020, 7:41 PM

algent requested review of this revision.Jul 6 2020, 7:41 PM

JoshStrobl added a subscriber: JoshStrobl.Jul 8 2020, 4:45 PM

JoshStrobl added inline comments.

pspec_x86_64.xml
26	Is this right? This seems more like a bug than anything

I have to check this with the developer:
/usr/share/Crow Translate/Crow Translate/translations/crow-translate_es_ES.qm
Better fixing this upstream.

Yea don't get me wrong, the patch looks good to me, but mind if I hold off until this is fixed upstream?

Issue seems to be at https://github.com/crow-translate/crow-translate/blob/master/CMakeLists.txt#L156

I checked with QOwnNotes and they put translation QM files in /usr/share/QOwnNotes/languages which seems more reasonable.

According to developer this is intended.

This is intended. I not hardcoded this path, I just used built-in method to get it.
This is because the application have the same name as the company (Crow Translate). And Qt looks at /usr/share/Company/App Name/ on Linux.

@JoshStrobl If you think that we need to patch translations folder, then let me know.