Page MenuHomeSolus

Update nvme-cli to 1.12
ClosedPublic

Authored by silke on Jul 4 2020, 9:22 PM.
Tags
None
Referenced Files
F11020519: D9187.id22142.diff
Mon, Aug 7, 6:14 AM
F10816840: D9187.id22187.diff
Jun 1 2023, 4:10 AM
F10816834: D9187.id22184.diff
Jun 1 2023, 4:07 AM
F10816833: D9187.id22142.diff
Jun 1 2023, 4:07 AM
F10816806: D9187.diff
Jun 1 2023, 4:01 AM
F10775545: D9187.id.diff
May 22 2023, 9:10 PM
Subscribers

Details

Summary

Update nvme-cli to 1.12.

There is no changelog, so for the full changeset see:
https://github.com/linux-nvme/nvme-cli/compare/v1.8.1...v1.12

Resolves T9118.

Test Plan

Run nvme list, id-ctrl and nvme smart-log for my NVMe device.

Diff Detail

Repository
R3462 nvme-cli
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

silke requested review of this revision.Jul 4 2020, 9:22 PM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM. Please add the following as the MAINTAINERS.md file and replace the relevant info:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME
package.yml
23

So why aren't we packaging it? No reason to have a check that is completely commented out.

This revision now requires changes to proceed.Jul 8 2020, 4:36 PM

Add MAINTAINERS and remove commented check

package.yml
23

Turns out the tests *also* require an NVMe disk, so I have removed it entirely.

LGTM. Thank you for the patch and taking up maintainership of this. It's much appreciated.

package.yml
23

Ah. Well thanks for the removal.

This revision is now accepted and ready to land.Jul 8 2020, 5:29 PM
This revision was automatically updated to reflect the committed changes.