Page MenuHomeSolus

Update nfft to 3.5.1
ClosedPublic

Authored by hashhsah on Jul 3 2020, 7:52 PM.

Details

Summary

Update nfft to 3.5.1 and add octave binding. Resolves T9116.

A changelog from 3.4.x can be found at https://github.com/NFFT/nfft/blob/develop/ChangeLog

Test Plan
  • python binding:
    • pip install nfft-cffi
    • # extract tests/test_nfft.py from nfft-cffi tarball
    • nosetests test_nfft.py
    • # all tests should pass
  • octave binding:
    • octave
    • addpath('/usr/share/nfft/matlab/nfft/', '/usr/lib64')
    • simple_test

Diff Detail

Repository
R3839 nfft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hashhsah created this revision.Jul 3 2020, 7:52 PM
hashhsah requested review of this revision.Jul 3 2020, 7:52 PM
hashhsah updated this revision to Diff 22114.Jul 3 2020, 7:55 PM

add maintainer.md

hashhsah updated this revision to Diff 22116.Jul 3 2020, 7:59 PM
hashhsah edited the summary of this revision. (Show Details)

add changelog

hashhsah updated this revision to Diff 22117.Jul 3 2020, 8:33 PM
hashhsah retitled this revision from update to 3.5.1 to Update nfft to 3.5.1.
hashhsah edited the summary of this revision. (Show Details)

revise MAINTAINER.md and diff title

JoshStrobl requested changes to this revision.Jul 8 2020, 3:52 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
2–3

You didn't bump the release number.

This revision now requires changes to proceed.Jul 8 2020, 3:52 PM
hashhsah updated this revision to Diff 22208.Jul 9 2020, 6:57 PM

bump revision number

hashhsah updated this revision to Diff 22210.Jul 9 2020, 7:02 PM
hashhsah edited the test plan for this revision. (Show Details)

fix typo in test plan

JoshStrobl accepted this revision.Jul 14 2020, 10:57 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 14 2020, 10:57 AM
This revision was automatically updated to reflect the committed changes.