Page MenuHomeSolus

Update nim to 1.2.2
ClosedPublic

Authored by akrenz on Wed, Jun 24, 9:25 PM.

Details

Summary

Update to 1.2.2

Changelog:

  • Fixes a critical error where 1 completed future with multiple awaits will cause only 1 await (the last one) to be awakened. Multiple other Minor issues fixed.

Full changelog available here.

Packager Notes:

  • Include zsh autocompletion (into site-functions) for nimble.
  • To build 1.2.2 we need to remove nim-gdb from install script, since these are missing in the src tarball. See this issue.
Test Plan

check if nimble autocompletion works in zsh and compile 3 example programms from https://nim-lang.org/

Diff Detail

Repository
R2167 nim
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Wed, Jun 24, 9:25 PM
akrenz requested review of this revision.Wed, Jun 24, 9:25 PM
JoshStrobl requested changes to this revision.Fri, Jun 26, 9:22 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
32

functions are shipped by zsh, site-functions is third-party ones.

This revision now requires changes to proceed.Fri, Jun 26, 9:22 AM

Changelog should also be linked or summarized.

akrenz updated this revision to Diff 22076.Sat, Jun 27, 6:26 PM
akrenz edited the summary of this revision. (Show Details)

Added changelog and moved zsh completion from functions into site-functions.

akrenz marked an inline comment as done.Sat, Jun 27, 6:26 PM
JoshStrobl requested changes to this revision.Wed, Jul 1, 6:36 AM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added inline comments.
pspec_x86_64.xml
317

You didn't rebuild it so it's still reporting the incorrect directory.

This revision now requires changes to proceed.Wed, Jul 1, 6:37 AM
akrenz updated this revision to Diff 22108.Thu, Jul 2, 8:06 PM

Rebuild to update pspec file

akrenz marked an inline comment as done.Thu, Jul 2, 8:06 PM
JoshStrobl accepted this revision.Wed, Jul 8, 5:37 PM
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks. Went ahead and fixed summary myself.

This revision is now accepted and ready to land.Wed, Jul 8, 5:38 PM
This revision was automatically updated to reflect the committed changes.