Page MenuHomeSolus

Update Redis to 6.0.5
ClosedPublic

Authored by maveonair on Wed, Jun 24, 7:06 PM.

Details

Summary
Test Plan

Started a server and run a few commands with redis-cli

Diff Detail

Repository
R2799 redis
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

maveonair created this revision.Wed, Jun 24, 7:06 PM
maveonair requested review of this revision.Wed, Jun 24, 7:06 PM

Don't really know what to do with this patch. The patch itself looks fine, though @YakoYakoYokuYoku did offer to become maintainer of this per T9124. Would hate to throw away this work but haven't seen any movement since the initial post by them in June. Pinging Yako for thoughts.

Well I wanted to offer a patch that makes redis stateless with local an system configurations (like samba for example), although I have the configs working I can't offer atm that the running instance of redis-server systemd service has redis storage dumping (see persistance section at the docs) and I hit that wall when the redis sysuser doesn't have the permissions to write in my desired location.
In brevi if we want to make this stateless it has to be in the future, otherwise this patch LGTM.

Short note I'm a guy, refering "them" to me gives me a lot of confusion 🤡🤡🤡🤡

JoshStrobl accepted this revision.Wed, Jul 8, 5:46 PM

Yea at the moment getting it updated has higher priority than making it stateless, so going to accept this patch. Thanks for the comments and thank you @maveonair for the patch!

This revision is now accepted and ready to land.Wed, Jul 8, 5:46 PM
This revision was automatically updated to reflect the committed changes.