Page MenuHomeSolus
Differential D9072

Fix Vala missing cast to uint8[] build error
ClosedPublic
Actions

Authored by akrenz on Jun 17 2020, 10:09 AM.
Tags
None
Referenced Files
F11022990: D9072.id21876.diff
Tue, Aug 8, 7:44 AM
F10972971: D9072.diff
Fri, Jul 21, 5:33 PM
F10948750: D9072.id21840.diff
Sat, Jul 15, 11:50 PM
F10753032: D9072.id21876.diff
May 16 2023, 4:53 PM
F10753015: D9072.id21840.diff
May 16 2023, 4:51 PM
F10753009: D9072.id21841.diff
May 16 2023, 4:51 PM
F10752941: D9072.diff
May 16 2023, 4:40 PM
F10732965: D9072.diff
May 11 2023, 6:43 PM
View All 10 Files
Subscribers
algent
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R4413:3bcc8f21560a: Fix Vala missing cast to uint8[] build error
Summary

Rebuild easyssh with locally updated granite (5.4.0) and applied patch to fix "Cannot convert from char[]' to unowned uint8[]?'" errors.

Depends on D8999

Test Plan

Install updated granite (5.4.0) and installed easyssh connecting to my NAS, browsing files and make sure it displays characters like äöüß correctly. make sure all GUI elements are displayed correctly (due to updated granite)

Diff Detail

Repository
R4413 easyssh
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

akrenz created this revision.Jun 17 2020, 10:09 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJun 17 2020, 10:09 AM
akrenz requested review of this revision.Jun 17 2020, 10:09 AM
algent added a subscriber: algent.Jun 17 2020, 10:12 AM

you forgot to do make bump before building this.

akrenz updated this revision to Diff 21841.Jun 17 2020, 10:19 AM

@algent Just saw that after submitting the patch. Shame on me.

Bumped revision.

DataDrake accepted this revision.Jun 17 2020, 12:51 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 17 2020, 12:51 PM
Closed by commit R4413:3bcc8f21560a: Fix Vala missing cast to uint8[] build error (authored by akrenz, committed by JoshStrobl). · Explain WhyJun 17 2020, 5:22 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R4413:3bcc8f21560a: Fix Vala missing cast to uint8[] build error.

Revision Contents
Changeset List

PathSize
files/
44 lines
3 lines
12 lines

Diff 21876

View Options

files/utf8.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.