Page MenuHomeSolus

Fix Vala missing cast to uint8[] build error
ClosedPublic

Authored by akrenz on Wed, Jun 17, 10:09 AM.

Details

Summary

Rebuild easyssh with locally updated granite (5.4.0) and applied patch to fix "Cannot convert from char[]' to unowned uint8[]?'" errors.

Depends on D8999

Test Plan

Install updated granite (5.4.0) and installed easyssh connecting to my NAS, browsing files and make sure it displays characters like äöüß correctly. make sure all GUI elements are displayed correctly (due to updated granite)

Diff Detail

Repository
R4413 easyssh
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Wed, Jun 17, 10:09 AM
akrenz requested review of this revision.Wed, Jun 17, 10:09 AM
algent added a subscriber: algent.Wed, Jun 17, 10:12 AM

you forgot to do make bump before building this.

akrenz updated this revision to Diff 21841.Wed, Jun 17, 10:19 AM

@algent Just saw that after submitting the patch. Shame on me.

Bumped revision.

DataDrake accepted this revision.Wed, Jun 17, 12:51 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Wed, Jun 17, 12:51 PM
This revision was automatically updated to reflect the committed changes.