Differential D9031

Initial Inclusion of canta-gtk-theme
ClosedPublic
Actions

Authored by TeenCorn on Jun 10 2020, 12:05 AM.

Tags

None

Referenced Files

	F11046808: D9031.id21928.diff
	Thu, Aug 10, 2:12 PM

	F11046807: D9031.id.diff
	Thu, Aug 10, 2:12 PM

	F11046806: D9031.id21711.diff
	Thu, Aug 10, 2:12 PM

	F11046805: D9031.id21963.diff
	Thu, Aug 10, 2:12 PM

	F11046804: D9031.id21813.diff
	Thu, Aug 10, 2:12 PM

	F11046803: D9031.id21891.diff
	Thu, Aug 10, 2:12 PM

	F11046802: D9031.id21962.diff
	Thu, Aug 10, 2:12 PM

	F11032531: D9031.diff
	Wed, Aug 9, 2:23 PM

View All 24 Files

Subscribers

Details

Reviewers

DataDrake
JoshStrobl

Group Reviewers

Maniphest Tasks

T6030: Canta-theme

Commits

R5008:f19d9b9cb8e5: Initial Inclusion of canta-gtk-theme

Summary

This inclusion fixes T6030

Test Plan

Install and make sure each theme variant works.

Diff Detail

Repository

R5008 canta-gtk-theme

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

TeenCorn created this revision.Jun 10 2020, 12:05 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 10 2020, 12:05 AM

TeenCorn requested review of this revision.Jun 10 2020, 12:05 AM

Please add a MAINTAINERS.md file listing yourself as maintainer.

This revision now requires changes to proceed.Jun 13 2020, 3:17 PM

Added MAINTAINER.md

JoshStrobl requested changes to this revision.Jun 17 2020, 12:31 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
19	This needs to be a list similar to patterns, it isn't a stage like install.

This revision now requires changes to proceed.Jun 17 2020, 12:31 PM

Fixed oof

JoshStrobl requested changes to this revision.Jun 20 2020, 2:49 PM

JoshStrobl added inline comments.

package.yml
22	Excessive spacing after install.sh
23	Don't remove xfwm4. Can be used in some twms.
pspec_x86_64.xml
23	All AUTHORS and COPYING files from all sub themes should be removed. You can do this using glob-based removals.

This revision now requires changes to proceed.Jun 20 2020, 2:49 PM

Fixed spacing, added back xfwm4, and removed COPYING and AUTHOR files from all sub themes.

We have a real name policy for accountability. While I'm sure TeenCorn is a nice name, I doubt it's your actual name :P

Identity compromised ;(

It's okay you're still teencorn in our hearts.

Thanks for the patch. Be sure to update your .solus/packager so future updates correctly set the update's Name value.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 22 2020, 6:59 PM

Closed by commit R5008:f19d9b9cb8e5: Initial Inclusion of canta-gtk-theme (authored by TeenCorn, committed by JoshStrobl). · Explain Why

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5008:f19d9b9cb8e5: Initial Inclusion of canta-gtk-theme.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

23 lines

pspec_x86_64.xml

13363 lines

Diff 21963

MAINTAINERS.md

Loading...

Makefile

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...