Paths

Table of Contentst

Differential D9011

Update ipscan to 3.7.2
ClosedPublic
Actions

Authored by • serebit on Jun 6 2020, 9:59 PM.

Tags

None

Referenced Files

	F11047880: D9011.id21800.diff
	Thu, Aug 10, 3:54 PM

	F11047879: D9011.id.diff
	Thu, Aug 10, 3:54 PM

	F11047878: D9011.id21685.diff
	Thu, Aug 10, 3:54 PM

	F11033415: D9011.diff
	Wed, Aug 9, 3:40 PM

	F11016707: D9011.diff
	Sat, Aug 5, 7:23 PM

	F10916882: D9011.id.diff
	Jul 8 2023, 2:29 PM

	F10866657: D9011.diff
	Jun 17 2023, 4:42 PM

	F10850834: D9011.id21685.diff
	Jun 12 2023, 7:31 AM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T6658: OpenJDK & OpenJFX Upgrade to 11

Commits

R1482:52ffa5277903: Update ipscan to 3.7.2

Summary

Additionally, use JDK11 for both build and runtime.

Notable changes between this version and 3.7.0:

Add a new Java Built-in pinger by default (InetAddress.isReachable()), which uses ICMP if enough privileges or falls back to TCP port 7
Fix handling of escape sequences in HTTP Sender
Enable ICMP Echo pinger for Linux

Full release notes are available here.

Test Plan

Scan some IPs!

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• serebit created this revision.Jun 6 2020, 9:59 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 6 2020, 9:59 PM

• serebit requested review of this revision.Jun 6 2020, 9:59 PM

• serebit added a task: T6658: OpenJDK & OpenJFX Upgrade to 11.Jun 6 2020, 9:59 PM

• serebit added a parent revision: D8980: Update Gradle to 6.5.0.

livingsilver94 added subscribers: DataDrake, livingsilver94.Jun 6 2020, 10:03 PM

livingsilver94 added inline comments.

files/ipscan
3–5	Hm is this actually a good idea? Better to ask @DataDrake, but it is my understanding that we want to allow users to specify JAVA_HOME only for packages aimed at building applications (gradle, ant, apache, sbt. Maybe even scala but idk).

• serebit added inline comments.Jun 6 2020, 10:05 PM

files/ipscan
3–5	I figured it couldn't hurt, but if core would rather not allow it then I can change the diff.

livingsilver94 added inline comments.Jun 6 2020, 10:06 PM

files/ipscan
3–5	With "apache" I meant "maven" but yeah you get the point.

LGTM. Thanks!

I don't really think it hurts to have the ability to override JAVA_HOME, though I don't think everything needs it either.

This revision is now accepted and ready to land.Jun 13 2020, 3:41 PM

Closed by commit R1482:52ffa5277903: Update ipscan to 3.7.2 (authored by • serebit, committed by DataDrake). · Explain WhyJun 13 2020, 10:37 PM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R1482:52ffa5277903: Update ipscan to 3.7.2.

Revision Contents
Changeset List

Path

Size

files/

0001-disable-deb-rpm-minimize.patch

fix-build-gradle.patch

49 lines

6 lines

21 lines

pspec_x86_64.xml

14 lines

Diff 21685

files/0001-disable-deb-rpm-minimize.patch

Loading...

files/fix-build-gradle.patch

Loading...

files/ipscan

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...