Update granite to 5.4.0
ClosedPublic
Actions

Authored by akrenz on Jun 5 2020, 10:40 PM.

Details

Reviewers

DataDrake
JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T9001: Update granite to 5.4.0

Commits

R1052:2b0ba28a74b1: Update granite to 5.4.0

Summary

Fixes T9001

New Features:

New Settings class to share Pantheon desktop settings with apps
Introduced Settings.prefers_color_scheme to get a user's color scheme preference, i.e. for a dark style

Deprecations:

It is now recommended to use GLib.Settings instead of Granite.Services.Settings

Improvements:

Better align labels in settings sidebars
Make AccelLabel.label settable
Updated translations

Test Plan

After Installation run /usr/bin/granite-demo and gone through all demo widgets and make sure everything works.

Rebuild

vocal
noise
playmyvideos
bookworm
nasc
sequeler

and make sure each application works as expected (playing some music/video and listening to "1619" podcas in Vocal, do some simple calculations with nasc and connect to a test DB with seuqler). Verified all GUI elements are shown and work as expected.

Diff Detail

Repository

R1052 granite

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

akrenz created this revision.Jun 5 2020, 10:40 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 5 2020, 10:40 PM

akrenz requested review of this revision.Jun 5 2020, 10:40 PM

Is there any changelog to add in the Summary?

In D8999#146599, @livingsilver94 wrote:

Is there any changelog to add in the Summary?

Added changes to summary

streambinder added a subscriber: streambinder.Jun 6 2020, 9:29 PM

Missing changes to abi_ files. You MUST have these, they are critical to informing the rebuild process.

This revision now requires changes to proceed.Jun 13 2020, 3:53 PM

Add abi_* files to patch

After Installation run /usr/bin/granite-demo and gone through all demo widgets and make sure everything works.

What about the apps in our repo that require Granite? Tootle, Playmyvideos, Noise, Vocal, etc.

This revision now requires changes to proceed.Jun 14 2020, 8:42 PM

Added rebuilds for vocal and noise to testplan.

Update Testplan for rebuilds of playmyvideos, nasc, sequeler, bookworm.

Could not rebuild coin (repository removed), tootle (Vala error) and easyssh (Vala error).

akrenz edited the test plan for this revision. (Show Details)Jun 17 2020, 8:02 AM

In D8999#147902, @akrenz wrote:

Update Testplan for rebuilds of playmyvideos, nasc, sequeler, bookworm.

Could not rebuild coin (repository removed), tootle (Vala error) and easyssh (Vala error).

What's the issue with Valafor tootle and easyssh, exactly?

akrenz added a child revision: D9072: Fix Vala missing cast to uint8[] build error.Jun 17 2020, 10:09 AM