Differential D8994

Update apache-ant to 1.10.8
ClosedPublic
Actions

Authored by • serebit on Jun 5 2020, 6:58 PM.

Tags

None

Referenced Files

	F11047898: D8994.id21784.diff
	Thu, Aug 10, 3:55 PM

	F11047897: D8994.id21661.diff
	Thu, Aug 10, 3:55 PM

	F11047896: D8994.id.diff
	Thu, Aug 10, 3:55 PM

	F11047895: D8994.id21668.diff
	Thu, Aug 10, 3:55 PM

	F11033420: D8994.diff
	Wed, Aug 9, 3:40 PM

	F11024663: D8994.diff
	Tue, Aug 8, 11:13 PM

	F10998185: D8994.id21661.diff
	Thu, Jul 27, 7:30 PM

	F10866654: D8994.id21784.diff
	Jun 17 2023, 4:41 PM

View All 22 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T6658: OpenJDK & OpenJFX Upgrade to 11

Commits

R365:2440badb9809: Update apache-ant to 1.10.8

Summary

Additionally, use openjdk-11 for build and runtime.

Notable changes:

Fix a regression in javac task involving command line argument files
sshexec failed to write output to a file if the file didn't exist
Fix "legacy-xml" formatter of junitlauncher task not writing out the stacktrace for failures

Full changelog is available here.

Test Plan

Build josm from source

Diff Detail

Repository

R365 apache-ant

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• serebit created this revision.Jun 5 2020, 6:58 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 5 2020, 6:58 PM

• serebit requested review of this revision.Jun 5 2020, 6:58 PM

• serebit added a parent revision: D8979: Un-bootstrap openjdk-11 and integrate OpenJFX.Jun 5 2020, 7:01 PM

• serebit added a child revision: D8995: Use openjdk-11 for josm.Jun 5 2020, 7:29 PM

• serebit added a child revision: D8996: Update sbt to 1.3.12.Jun 5 2020, 7:47 PM

• serebit added a task: T6658: OpenJDK & OpenJFX Upgrade to 11.Jun 5 2020, 8:36 PM

livingsilver94 added a subscriber: livingsilver94.Jun 5 2020, 8:51 PM

livingsilver94 added inline comments.

files/0001-Default-to-using-openjdk-11.patch
22	To be fair, maven allows to specify another JAVA_HOME while at its current state, ant doesn't, this patch forces a value. Would you take the effort to make ant behave similarly to maven? DISCLAIMER: you may want to check my statements before going ahead, I could remember wrong.

• serebit added inline comments.Jun 5 2020, 8:57 PM

files/0001-Default-to-using-openjdk-11.patch
22

• serebit planned changes to this revision.Jun 5 2020, 9:10 PM

Use a similar Java shim to scala and kotlin-native, allowing specification of JAVA_HOME by the user

• serebit added a child revision: D9021: Use openjdk-8 to build jitsi with ant.Jun 8 2020, 2:49 AM

• serebit added a child revision: D9028: Use JDK11 for projectlibre.Jun 9 2020, 12:06 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 13 2020, 4:02 PM

• serebit removed a parent revision: D8979: Un-bootstrap openjdk-11 and integrate OpenJFX.Jun 13 2020, 7:12 PM

• serebit added a child revision: D8979: Un-bootstrap openjdk-11 and integrate OpenJFX.

Closed by commit R365:2440badb9809: Update apache-ant to 1.10.8 (authored by • serebit, committed by DataDrake). · Explain WhyJun 13 2020, 8:31 PM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R365:2440badb9809: Update apache-ant to 1.10.8.

Revision Contents
Changeset List

Path

Size

files/

	0001-Default-to-using-openjdk-11.patch
	0001-Default-to-using-openjdk-8.patch

2 lines

0001-Default-to-using-openjdk-8.patch

14 lines

pspec_x86_64.xml

14 lines

Diff 21661

files/0001-Default-to-using-openjdk-11.patch

Loading...

files/0001-Default-to-using-openjdk-8.patch

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...