Page MenuHomeSolus

Update boostnote to 0.15.3
ClosedPublic

Authored by akrenz on Jun 2 2020, 1:32 AM.

Details

Summary

Fixes T8963.

This is an update for the legacy version of boostnote. The newer version mentioned in the Update reuqest was Boostnote.next, which is incompatible with the legacy version of the app. Therefor it should not silently replace the legacy version, but should be added as a new package with "replaces" flag.

Test Plan

Created/edited/deleted Multiple notes and folders. Tried opening an old note storage creatd with the previous version.

Diff Detail

Repository
R4324 boostnote
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Jun 2 2020, 1:32 AM
akrenz requested review of this revision.Jun 2 2020, 1:32 AM
JoshStrobl accepted this revision.Jun 4 2020, 12:56 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

P.S. In response to your comment of "Therefor it should not silently replace the legacy version, but should be added as a new package with "replaces" flag." - This is effectively the same as just upgrading this version. The individual isn't going to get an option during upgrade to not replace it. I think either some heads up should be given, or we should figure out a way to ship both of them as co-installable (though that'd involve considerable effort to change install paths, patch config paths, etc.).

That being said, I'd like to know what is actually incompatible. At least according to this issue, they're just using a file hierarchy and leveraging CSON in the "legacy" implementation. Was this changed in the "next" version to something which leverages a database (sqlite, indexeddb, drivers for other stuff like postgresql, etc.)?

This revision is now accepted and ready to land.Jun 4 2020, 12:56 PM
This revision was automatically updated to reflect the committed changes.