Page MenuHomeSolus
Differential D8973

Update leveldb to 1.22
ClosedPublic
Actions

Authored by YakoYakoYokuYoku on Jun 1 2020, 1:47 PM.
Tags
Referenced Files
F11068285: D8973.diff
Fri, Aug 11, 9:35 PM
F11052212: D8973.id21956.diff
Thu, Aug 10, 8:58 PM
F11052210: D8973.id21655.diff
Thu, Aug 10, 8:58 PM
F11052209: D8973.id21653.diff
Thu, Aug 10, 8:58 PM
F11052208: D8973.id21659.diff
Thu, Aug 10, 8:58 PM
F11052207: D8973.id.diff
Thu, Aug 10, 8:58 PM
F11052206: D8973.id21583.diff
Thu, Aug 10, 8:58 PM
F11036821: D8973.diff
Wed, Aug 9, 7:47 PM
View All 22 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R1619:c916c1a777a3: Update leveldb to 1.22
Summary

The build system changed to CMake.
Links for the changes:

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Built pytorch and minetest against it, played a minetest a bit.

Diff Detail

Repository
R1619 leveldb
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

YakoYakoYokuYoku created this revision.Jun 1 2020, 1:47 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJun 1 2020, 1:47 PM
YakoYakoYokuYoku requested review of this revision.Jun 1 2020, 1:47 PM
YakoYakoYokuYoku added a child revision: D8974: Update wiredtiger to 3.3.0.Jun 1 2020, 1:53 PM
JoshStrobl requested changes to this revision.Jun 5 2020, 11:36 AM
JoshStrobl added a subscriber: JoshStrobl.

Additional revdeps need testing. At the very least, libtorch and pytorch should be rebuilt, minetest should be rebuilt and validated.

package.yml
17

You remove Peter's patch but didn't remove the file. Are you sure it's using our flags?

This revision now requires changes to proceed.Jun 5 2020, 11:36 AM
YakoYakoYokuYoku updated this revision to Diff 21653.Jun 5 2020, 3:34 PM
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Update test plan

YakoYakoYokuYoku updated this revision to Diff 21655.Jun 5 2020, 3:51 PM

Remove the C/C++ flags patch

YakoYakoYokuYoku marked an inline comment as done.Jun 5 2020, 3:53 PM
YakoYakoYokuYoku added inline comments.
package.yml
17

I've recursively ripgrepped the leveldb sources and in any place a modification of the C/C++ flags was shown.

YakoYakoYokuYoku updated this revision to Diff 21659.Jun 5 2020, 6:09 PM
YakoYakoYokuYoku marked an inline comment as done.
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Validate minetest

YakoYakoYokuYoku added a project: Requires Rebuilds.Jun 5 2020, 6:10 PM
kyrios123 removed a child revision: D8974: Update wiredtiger to 3.3.0.Jun 18 2020, 5:21 PM
JoshStrobl accepted this revision.Jun 20 2020, 2:51 PM

LGTM, will get this landed after all the libboost stuff next week. Remind me if it's not in by Thursday or so please.

This revision is now accepted and ready to land.Jun 20 2020, 2:51 PM
Closed by commit R1619:c916c1a777a3: Update leveldb to 1.22 (authored by YakoYakoYokuYoku, committed by JoshStrobl). · Explain WhyJun 22 2020, 6:05 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R1619:c916c1a777a3: Update leveldb to 1.22.

Revision Contents
Changeset List

Diff 21956

View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

files/Use-Solus-flags.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.