Page MenuHomeSolus

Update leveldb to 1.22
ClosedPublic

Authored by YakoYakoYokuYoku on Jun 1 2020, 1:47 PM.

Details

Summary

The build system changed to CMake.
Links for the changes:

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Built pytorch and minetest against it, played a minetest a bit.

Diff Detail

Repository
R1619 leveldb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Jun 1 2020, 1:47 PM
JoshStrobl requested changes to this revision.Jun 5 2020, 11:36 AM
JoshStrobl added a subscriber: JoshStrobl.

Additional revdeps need testing. At the very least, libtorch and pytorch should be rebuilt, minetest should be rebuilt and validated.

package.yml
17

You remove Peter's patch but didn't remove the file. Are you sure it's using our flags?

This revision now requires changes to proceed.Jun 5 2020, 11:36 AM
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Update test plan

Remove the C/C++ flags patch

YakoYakoYokuYoku marked an inline comment as done.Jun 5 2020, 3:53 PM
YakoYakoYokuYoku added inline comments.
package.yml
17

I've recursively ripgrepped the leveldb sources and in any place a modification of the C/C++ flags was shown.

YakoYakoYokuYoku marked an inline comment as done.
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Validate minetest

JoshStrobl accepted this revision.Jun 20 2020, 2:51 PM

LGTM, will get this landed after all the libboost stuff next week. Remind me if it's not in by Thursday or so please.

This revision is now accepted and ready to land.Jun 20 2020, 2:51 PM
This revision was automatically updated to reflect the committed changes.