Page MenuHomeSolus

Update x264 to 0.159.2999
ClosedPublic

Authored by aleksvor on May 31 2020, 9:59 AM.
Referenced Files
F10879745: D8966.id21574.diff
Jun 22 2023, 5:51 AM
F10876625: D8966.id21635.diff
Jun 20 2023, 12:05 PM
F10871966: D8966.diff
Jun 18 2023, 8:35 PM
F10821639: D8966.id21574.diff
Jun 2 2023, 1:07 PM
F10810813: D8966.diff
May 30 2023, 8:43 PM
F10805118: D8966.id21635.diff
May 29 2023, 6:47 PM
F10805117: D8966.id21574.diff
May 29 2023, 6:47 PM
F10805116: D8966.id.diff
May 29 2023, 6:47 PM
Subscribers

Details

Summary

This commit addresses following issues:

  1. Moves package to new source - snapshotting service was deprecated in favor of VideoLAN's GitLab instance. The commit is taken from "stable" branch, also I have added a note about updates for future packagers.
  2. Uses version string reported by x264 --version. For future reference - it can be determined as "0.<ABI version>.<Number of commits>".
  3. Disables debug info. This option conflicts with --enable-lto flag and takes preference over it. Look at configure script and our last build log to see the configuration logic and our resulting build config where LTO is not actually used.
  4. Enables --system-libx264 flag so x264 binary links with shared libx264 library. The default behavior is to build static libx264 and compile it in x264 executable to get portable binary. This reduces the size of the package due to reducing duplication of binary code.
Test Plan
  1. Rebuilt packages:
    • avidemux
    • ffmpeg
    • gst-plugins-ugly
    • gstreamer-plugins-1.0-ugly
    • handbrake
    • obs-studio
    • vlc
  2. Encoded video in H264 from Y4M using x264 executable. Checked that CPU instruction sets are properly detected and used.
  3. Encoded video in H264 from VC-1 using FFmpeg and HandBrake.

Diff Detail

Repository
R3187 x264
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Regarding a lot of missing ABI symbols - I have looked into this and it seems that they are actually private symbols that are now properly hidden. As mentioned in the test plan, I made sure that all revdeps are building correctly against this version and optimized assembly routines are properly used on CPUs that support them.

JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks! Just doing a pull of the repo source locally at the moment then will do rebuilds post landing this.

This revision is now accepted and ready to land.Jun 4 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.