Page MenuHomeSolus

Fix path checking in projectlibre executable
AbandonedPublic

Authored by livingsilver94 on May 25 2020, 12:11 PM.
Tags
None
Referenced Files
F11047886: D8936.diff
Thu, Aug 10, 3:55 PM
F11023742: D8936.diff
Tue, Aug 8, 4:13 PM
F10870462: D8936.diff
Jun 18 2023, 9:19 AM
F10845438: D8936.id21520.diff
Jun 11 2023, 12:28 AM
F10827340: D8936.diff
Jun 4 2023, 5:10 AM
F10705899: D8936.id.diff
Apr 26 2023, 2:10 PM

Details

Summary

Fix a bug where the projectlibre executable script failed to check the non-existence of the XDG_CONFIG_HOME variable, due to missing quote marks. In fact test -d returns true, whereas test -d "" returns false as we expected.

Fixes T9023.

Test Plan
unset XDG_CONFIG_HOME
projectlibre

Now projectlibre starts correctly.

Diff Detail

Repository
R4185 projectlibre
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

LGTM but your summary needs to be fixed. We're in the 21st century, 80 col should not be a thing :P

DataDrake added a subscriber: DataDrake.

80 cols.

This revision now requires changes to proceed.Jun 2 2020, 2:12 AM

TBH I just wrote the summary as I felt it comfortable in the terminal, the 80-cols rule came out unintentionally :P

serebit added a subscriber: serebit.

Abandoning in favor of D9028, with credit given in summary! Thanks for the fix <3