Page MenuHomeSolus

Update nim to Version 1.2.0
ClosedPublic

Authored by akrenz on May 24 2020, 10:01 PM.

Details

Summary

Update nim to Version 1.2.0

Fixes T8979

Test Plan

Run Unit tests from nim Package and also compiled the 3 example programms from https://nim-lang.org/. Also tried nimble

  • Creating a project via nimble init test
  • Building test project by nimble build test
  • Downloading package list via nimble refresh
  • Download different packages via nimble install <package>

Diff Detail

Repository
R2167 nim
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.May 24 2020, 10:01 PM
akrenz requested review of this revision.May 24 2020, 10:01 PM
JoshStrobl requested changes to this revision.May 27 2020, 9:58 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/0001-Change-to-correct-dirs.patch
26

Except now it has unnecessary redundancy with the naming because it is now /etc/nim/nim*, when it can easily just be /etc/nim*. Please revert.

package.yml
15

Why was my comment removed?

34

Having the docs is kinda pointless given most people will be referencing online documentation anyways. We've been gradually phasing out local docs, so please remove that.

47

Nuke given request to remove docs.

This revision now requires changes to proceed.May 27 2020, 9:58 AM
akrenz added inline comments.May 27 2020, 7:40 PM
files/0001-Change-to-correct-dirs.patch
26

Configuration files need to be placed under /etc/nim, otherwise they do not get recognized by nim compiler (cannot load modules from standard library) . Also there are now 3 configuration files. Therefor it make sense to store them under a common directory

P.S. Folder structure is not /etc/nim/nim/nim,cfg but /etc/nim/nim.cfg like expected.

akrenz added inline comments.May 27 2020, 8:11 PM
package.yml
15

I thought this "#check" comment was automatically generated for the package.yml and was left by error?

akrenz updated this revision to Diff 21549.May 27 2020, 8:11 PM
akrenz edited the summary of this revision. (Show Details)

remove separate doc package

akrenz marked 2 inline comments as done.May 27 2020, 8:12 PM
JoshStrobl requested changes to this revision.Jun 4 2020, 12:42 PM

Otherwise LGTM

package.yml
15

No, I intentionally have it there to indicate why it's a builddep. Please add it back.

This revision now requires changes to proceed.Jun 4 2020, 12:42 PM
akrenz added a comment.Jun 5 2020, 6:29 AM

@JoshStrobl Are you ok if I stepup as Maintainer for this package?

Go for it, one less thing for me to maintain.

akrenz updated this revision to Diff 21667.Jun 5 2020, 9:12 PM

Added the "check" comment back and changed Maintainer to myself

akrenz marked an inline comment as done.Jun 5 2020, 9:12 PM
JoshStrobl accepted this revision.Fri, Jun 12, 12:16 PM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Jun 12, 12:16 PM
This revision was automatically updated to reflect the committed changes.