Update nim to Version 1.2.0
Fixes T8979
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T8979: Update Nim to 1.2.0
- Commits
- R2167:1469c0e6760f: Update nim to Version 1.2.0
Run Unit tests from nim Package and also compiled the 3 example programms from https://nim-lang.org/. Also tried nimble
- Creating a project via nimble init test
- Building test project by nimble build test
- Downloading package list via nimble refresh
- Download different packages via nimble install <package>
Diff Detail
Diff Detail
- Repository
- R2167 nim
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| files/0001-Change-to-correct-dirs.patch | ||
|---|---|---|
| 26 | Except now it has unnecessary redundancy with the naming because it is now /etc/nim/nim*, when it can easily just be /etc/nim*. Please revert. | |
| package.yml | ||
| 15 | Why was my comment removed? | |
| 34 | Having the docs is kinda pointless given most people will be referencing online documentation anyways. We've been gradually phasing out local docs, so please remove that. | |
| 47 | Nuke given request to remove docs. | |
| files/0001-Change-to-correct-dirs.patch | ||
|---|---|---|
| 26 | Configuration files need to be placed under /etc/nim, otherwise they do not get recognized by nim compiler (cannot load modules from standard library) . Also there are now 3 configuration files. Therefor it make sense to store them under a common directory P.S. Folder structure is not /etc/nim/nim/nim,cfg but /etc/nim/nim.cfg like expected. | |
| package.yml | ||
|---|---|---|
| 15 | I thought this "#check" comment was automatically generated for the package.yml and was left by error? | |
Comment Actions
Otherwise LGTM
| package.yml | ||
|---|---|---|
| 15 | No, I intentionally have it there to indicate why it's a builddep. Please add it back. | |