Page MenuHomeSolus

Update hub to 2.14.2
Needs ReviewPublic

Authored by yacn on Fri, May 22, 8:07 PM.

Details

Reviewers
kyrios123
Group Reviewers
Triage Team
Summary
  • Ensure man pages are shown at full width
  • Fix subject in ci-status docs
  • Indicate in docs that you can do plain git push after hub pr checkout
  • Fix using hub inside git worktree
  • Fixed script/build when running from within the downloaded hub tarball
  • New command: hub issue update
  • New command: hub issue transfer
  • Support git flag hub version --build-options
  • Refuse to follow HTTP 301/302 redirects for non-GET requests
  • Fix hub help <cmd> on Windows
  • Ensure that grep command is being used in shell completions
  • Consult global git config color.ui setting when --color=auto
  • Print more user-friendly HTTP 40x errors
  • Enable debugging file uploads via HUB_VERBOSE=1 hub release create -a <file>
  • Improve parsing malformed YAML config files
  • New command: hub gist
  • Add git pr show --format=... flag
  • Add hub api --obey-ratelimit flag
  • hub help: support compressed man pages
  • Add hub release download --include=PATTERN flag
  • hub help: Enable hub help --web <command>
  • hub release: Retry attaching release assets on 5xx server errors
  • hub pr checkout fixes
    • handle case when the PR given matches the current branch
    • avoid overriding existing branch merge config
  • hub release: Fail fast when attempting to attach unavailable files
  • Honor HTTPS_PROXY, NO_PROXY environment variables
  • Strip "co-authored-by" lines when populating PR body from git log
  • git compatibility: have hub <cmd> --help open the man page
  • hub fork bash completion improvements
  • hub pr fish completion improvements
  • hub compare: improve upstream branch detection & error messages
  • hub compare: allow slash character in branch names
  • hub api: fix GraphQL requests made to Enterprise hosts
  • Docs: clarify --message, --file, and --edit flags
  • Added hub pr to fish completions script
  • Have fish completions script wrap git if hub is aliased
  • Fix invocation of hub --paginate
  • Consistently expand all occurrences of {owner} and {repo} in hub api
  • Docs: unlist %NC/%Nc among available fields in hub pr list --format
  • GitHub Actions compatibility: infer GITHUB_USER value from GITHUB_REPOSITORY if available
  • Handle TERM signal during password prompt in terminal
  • Use consistent quote style in hub sync output
  • Allow hub use within GitHub Actions by specifying GITHUB_USER
  • Show friendlier error message when GITHUB_TOKEN is set, but fetching the current user fails
  • Improve pull-request push target detection for git config push.default is "upstream", but when the current branch does not have upstream configuration
  • hub pull-request: Avoid crash when the current branch is pushed to a non-GitHub remote
  • BROWSER environment variable now supports values with spaces in them (must be shell-quoted)
  • hub help: support man appearing in a path that has spaces
  • Docs: mention that comma-separated lists must not have spaces
  • Add hub api --paginate option to automatically fetch all pages of results
  • Add hub pr show [<number>] command to open a pull request in the browser
  • Add hub pull-request --no-maintainer-edits flag to disallow project maintainers being able to push to your branch
  • Abort hub pull-request with a helpful error message if the current branch wasn't pushed to a git remote
  • hub issue -M now accepts milestone names instead of just numbers
  • Drop support for legacy hub.http-clone git config value
  • Fix query git configuration when GIT_TRACE is used
  • Support detached HEAD if hub pull-request --head was passed
  • Fix newline in hub create error message
  • Ensure HTTP connection reuse across API calls
  • Avoid crash in hub remote argument parsing
  • Fix hub -C mydir merge <URL> by propagating global git arguments to Before/After chains
  • Preserve tilde ~ character in man pages
  • Fix non-draft pull requests for certain repositories
  • Create draft pull requests with hub pull-request --draft
  • Fix compatibility with git when run with no arguments: hub --git-dir=.git
  • Fix issue/PR --format %L output in no-color mode
  • Fix writing over existing cache files in hub api
  • Allow repository names that start with a - character
  • List api among custom hub commands in help
Test Plan
isaac@xps13 ~/packaging/hub $ which hub
which: no hub in (/home/isaac/bin:/sbin:/bin:/usr/sbin:/usr/bin:/snap/bin)
isaac@xps13 ~/packaging/hub $ sudo eopkg it hub-2.14.2-11-1-x86_64.eopkg
Password: 
Installation order: hub 
Installing hub, version 2.14.2, release 11
Extracting the files of hub
Installed hub
 [✓] Syncing filesystems                                                success
 [✓] Updating manpages database                                         success
isaac@xps13 ~/packaging/hub $ which hub
/usr/bin/hub
isaac@xps13 ~/packaging/hub $ hub --version
git version 2.26.2
hub version 2.14.2 
isaac@xps13 ~/packaging/hub $ pushd ~/git/etc/hub/ >/dev/null; hub release -L 5; popd >/dev/null
v2.14.2
v2.14.1
v2.14.0
v2.13.0
v2.12.8

Diff Detail

Repository
R1417 hub
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

yacn created this revision.Fri, May 22, 8:07 PM
yacn requested review of this revision.Fri, May 22, 8:07 PM
kyrios123 added a subscriber: kyrios123.EditedFri, May 22, 9:08 PM

This summary isn't actually a summary... and it's full of things that aren't relevant to us like all the Windows specific things that should be removed.
Explanation text like hereunder shouldn't be in the summary as well

Draft pull requests are considered work in progress: they don't automatically request others for review and they are not mergeable while in their draft state.

The reference to the issues #1234 must be stripped.
I'd also remove the version headings: the users needs an overview on the major changes between the current and the new version, it is not relevant to know exactly in which version something was changed since you're bumping several versions at once.

The test plan is very light, it is just a hub --version installing the package isn't actually part of the test. The test consists of briefly demonstrating the installed package actually works.

kyrios123 requested changes to this revision.Fri, May 22, 9:12 PM
This revision now requires changes to proceed.Fri, May 22, 9:12 PM
yacn added a comment.Fri, May 22, 9:23 PM

This summary isn't actually a summary... and it's full of things that aren't relevant to us like all the Windows specific things that should be removed.
Explanation text like hereunder shouldn't be in the summary as well

Draft pull requests are considered work in progress: they don't automatically request others for review and they are not mergeable while in their draft state.

I based my summary / commit message on the previous commits for updates to this package... which was adding the hub release notes for the version as they appear in the GitHub release as the summary. Since this bumped several major versions I figured I'd add all the release notes to be consistent.

The reference to the issues #1234 must be stripped.

why?

I'd also remove the version headings: the users needs an overview on the major changes between the current and the new version, it is not relevant to know exactly in which version something was changed since you're bumping several versions at once.

Sure, I'll fold them all into one giant list..

The test plan is very light, it is just a hub --version installing the package isn't actually part of the test. The test consists of briefly demonstrating the installed package actually works.

I followed what I read on "submitting a package" page, which reads:

If you are updating an existing package, please be sure to include a summarized changelog (or a link to the changelog provided upstream) and a test plan indicating that you’ve installed and run the package.

I did exactly that. If that's not sufficient, please update the documentation.

algent added a subscriber: algent.Fri, May 22, 9:31 PM

You can add a concrete test. From the github page there is a suggestion like:

$ hub clone rtomayko/tilt
#=> git clone git://github.com/rtomayko/tilt.git

# if you prefer HTTPS to git/SSH protocols:
$ git config --global hub.protocol https
$ hub clone rtomayko/tilt
#=> git clone https://github.com/rtomayko/tilt.git

Since I assume you are using it, there should be more commands available than

$ hub --version
yacn updated this revision to Diff 21504.Fri, May 22, 9:35 PM

Apply requested changes

yacn edited the summary of this revision. (Show Details)Fri, May 22, 9:45 PM
yacn edited the test plan for this revision. (Show Details)