Page MenuHomeSolus

Update coreutils to 8.32
AbandonedPublic

Authored by alecbcs on May 22 2020, 7:35 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Updated coreutils to 8.32 which includes multiple bug fixes in cp, dd, df, and ln. As well as new features in ls, id, and stat.

Summarized Changelog:

  • cp now copies /dev/fd/N correctly on platforms like Solaris where it is a character-special file whose minor device number is N.
  • dd conv=fdatasync no longer reports a "Bad file descriptor" error when fdatasync is interrupted, and dd now retries interrupted calls to close, fdatasync, fstat and fsync instead of incorrectly reporting an "Interrupted system call" error.
  • df now correctly parses the /proc/self/mountinfo file for unusual entries like ones with '\r' in a field value ("mount -t tmpfs tmpfs /foo$'\r'bar"), when the source field is empty ('mount -t tmpfs "" /mnt'), and when the filesystem type contains characters like a blank which need escaping.
  • factor again outputs immediately when stdout is a tty but stdin is not.
  • rmdir --ignore-fail-on-non-empty now works correctly for directories that fail to be removed due to permission issues. Previously the exit status was reversed, failing for non empty and succeeding for empty directories.
  • seq no longer prints an extra line under certain circumstances (such as seq -f "%g " 1000000 1000000').

Full changelog can be found here.

Test Plan

Tested 8.32 with included unit tests as well as installing on my machine for the last couple of days. New tests have been added since the last release and the latest version fails more of those. However installing on my machine and manually running chgrp, etc... I found nothing out of the ordinary expected results.

Diff Detail

Repository
R559 coreutils
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

alecbcs created this revision.May 22 2020, 7:35 PM
alecbcs requested review of this revision.May 22 2020, 7:35 PM
JoshStrobl requested changes to this revision.May 30 2020, 12:37 PM
JoshStrobl added a subscriber: JoshStrobl.

I'm pretty concerned by the fact the tests were disabled outright. This is part of system.base so testing is pretty important. If specific tests are broken I'd like to know why.

This revision now requires changes to proceed.May 30 2020, 12:37 PM