Page MenuHomeSolus
Differential D8917

Initial inclusion of Kronometer
AbandonedPublic
Actions

Authored by jwinnie on May 21 2020, 1:28 AM.
Tags
None
Referenced Files
F11063091: D8917.id21469.diff
Fri, Aug 11, 1:25 PM
F11042480: D8917.id21519.diff
Thu, Aug 10, 6:39 AM
F11037742: D8917.id21469.diff
Wed, Aug 9, 9:09 PM
F11037741: D8917.id21548.diff
Wed, Aug 9, 9:09 PM
F11037740: D8917.id21509.diff
Wed, Aug 9, 9:09 PM
F11037739: D8917.id21550.diff
Wed, Aug 9, 9:09 PM
F11037738: D8917.id21518.diff
Wed, Aug 9, 9:09 PM
F11037737: D8917.id21508.diff
Wed, Aug 9, 9:09 PM
View All 33 Files
Subscribers
DataDrake
JoshStrobl
livingsilver94

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Plasma
Maniphest Tasks
T9006: Kronometer
Summary

Resolves T9006.

Test Plan

I've been using Kronometer a lot for the past week and I've tested out all the features that I can figure out. I have yet to notice anything amiss.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jwinnie created this revision.May 21 2020, 1:28 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptMay 21 2020, 1:28 AM
jwinnie requested review of this revision.May 21 2020, 1:28 AM
JoshStrobl abandoned this revision.May 21 2020, 8:05 AM
JoshStrobl added a subscriber: JoshStrobl.

I'm not seeing a corresponding package request for this that has been approved, as per our documentation on submitting a package.

As such, abandoning.

jwinnie mentioned this in T9006: Kronometer.May 21 2020, 4:36 PM
jwinnie edited the summary of this revision. (Show Details)May 23 2020, 7:29 PM
jwinnie edited the test plan for this revision. (Show Details)
jwinnie added a reviewer: Plasma.
jwinnie added a task: T9006: Kronometer.
jwinnie updated this revision to Diff 21508.May 23 2020, 7:42 PM

Improve formatting of package.yml

jwinnie updated this revision to Diff 21509.May 23 2020, 7:44 PM

Fix broken git

jwinnie updated this revision to Diff 21510.May 23 2020, 7:48 PM

Try to fix git again

jwinnie added a comment.May 23 2020, 8:28 PM

Yikes, I messed up with the version control. I'll get back to this when I can find time.

jwinnie updated this revision to Diff 21518.May 25 2020, 3:25 AM

Try again to fix git

jwinnie updated this revision to Diff 21519.May 25 2020, 3:27 AM

Finally fix git :)

livingsilver94 added a subscriber: livingsilver94.May 25 2020, 8:24 AM
livingsilver94 added inline comments.
package.yml
6

Please use the CDN URL (cdn.download.kde.org/...) and the HTTPS protocol.

17–23

Sort them in alphabetical order.

34

Put a newline char at the of the file.
I'd also put a

check     : |
    %ninja_check

if tests don't take ages to complete, just to play safe.

jwinnie updated this revision to Diff 21548.May 27 2020, 7:33 PM

Address changes suggested by @livingsilver94

jwinnie updated this revision to Diff 21550.May 27 2020, 8:14 PM
jwinnie marked 3 inline comments as done.

Remove check because it fails

DataDrake requested changes to this revision.Jun 13 2020, 5:07 PM
DataDrake added a subscriber: DataDrake.
In D8917#145655, @jwinnie wrote:

Remove check because it fails

What failed?

package.yml
14

Make sure you don't have any redundant dependencies.

This revision now requires changes to proceed.Jun 13 2020, 5:07 PM
JoshStrobl abandoned this revision.Jun 17 2020, 8:41 AM

Closing since user is opting to go and create their own Linux distribution. I don't see a reason further support should be provided given that intent.

Revision Contents
Changeset List

PathSize
1 line
files/
61 lines
33 lines
169 lines

Diff 21518

View Options

Makefile

Loading...
View Options

files/0001-fix-name-conflict.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.