Page MenuHomeSolus

Initial inclusion of Kronometer
AbandonedPublic

Authored by jwinnie on May 21 2020, 1:28 AM.
Tags
None
Referenced Files
F11018211: D8917.id21518.diff
Sun, Aug 6, 10:13 AM
F11013286: D8917.diff
Fri, Aug 4, 12:10 PM
F11007470: D8917.diff
Tue, Aug 1, 7:46 PM
F11003389: D8917.id21509.diff
Mon, Jul 31, 2:23 PM
F10913766: D8917.id21508.diff
Jul 7 2023, 11:26 PM
F10868926: D8917.diff
Jun 18 2023, 1:16 AM
F10850731: D8917.id21519.diff
Jun 12 2023, 6:34 AM
F10847024: D8917.id21469.diff
Jun 11 2023, 8:40 AM

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Plasma
Maniphest Tasks
T9006: Kronometer
Summary

Resolves T9006.

Test Plan

I've been using Kronometer a lot for the past week and I've tested out all the features that I can figure out. I have yet to notice anything amiss.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.

I'm not seeing a corresponding package request for this that has been approved, as per our documentation on submitting a package.

As such, abandoning.

jwinnie edited the test plan for this revision. (Show Details)
jwinnie added a reviewer: Plasma.
jwinnie added a task: T9006: Kronometer.

Improve formatting of package.yml

Yikes, I messed up with the version control. I'll get back to this when I can find time.

livingsilver94 added inline comments.
package.yml
6

Please use the CDN URL (cdn.download.kde.org/...) and the HTTPS protocol.

17–23

Sort them in alphabetical order.

29

Put a newline char at the of the file.
I'd also put a

check     : |
    %ninja_check

if tests don't take ages to complete, just to play safe.

jwinnie marked 3 inline comments as done.

Remove check because it fails

DataDrake added a subscriber: DataDrake.

Remove check because it fails

What failed?

package.yml
13

Make sure you don't have any redundant dependencies.

This revision now requires changes to proceed.Jun 13 2020, 5:07 PM

Closing since user is opting to go and create their own Linux distribution. I don't see a reason further support should be provided given that intent.