Page MenuHomeSolus

Initial inclusion of Kronometer
Needs ReviewPublic

Authored by jwinnie on Thu, May 21, 1:28 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Plasma
Maniphest Tasks
T9006: Kronometer
Summary

Resolves T9006.

Test Plan

I've been using Kronometer a lot for the past week and I've tested out all the features that I can figure out. I have yet to notice anything amiss.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jwinnie created this revision.Thu, May 21, 1:28 AM
jwinnie requested review of this revision.Thu, May 21, 1:28 AM
JoshStrobl abandoned this revision.Thu, May 21, 8:05 AM
JoshStrobl added a subscriber: JoshStrobl.

I'm not seeing a corresponding package request for this that has been approved, as per our documentation on submitting a package.

As such, abandoning.

jwinnie edited the summary of this revision. (Show Details)Sat, May 23, 7:29 PM
jwinnie edited the test plan for this revision. (Show Details)
jwinnie added a reviewer: Plasma.
jwinnie added a task: T9006: Kronometer.
jwinnie updated this revision to Diff 21508.Sat, May 23, 7:42 PM

Improve formatting of package.yml

jwinnie updated this revision to Diff 21509.Sat, May 23, 7:44 PM

Fix broken git

jwinnie updated this revision to Diff 21510.Sat, May 23, 7:48 PM

Try to fix git again

Yikes, I messed up with the version control. I'll get back to this when I can find time.

jwinnie updated this revision to Diff 21518.Mon, May 25, 3:25 AM

Try again to fix git

jwinnie updated this revision to Diff 21519.Mon, May 25, 3:27 AM

Finally fix git :)

livingsilver94 added inline comments.
package.yml
6

Please use the CDN URL (cdn.download.kde.org/...) and the HTTPS protocol.

17–23

Sort them in alphabetical order.

29

Put a newline char at the of the file.
I'd also put a

check     : |
    %ninja_check

if tests don't take ages to complete, just to play safe.

jwinnie updated this revision to Diff 21548.Wed, May 27, 7:33 PM

Address changes suggested by @livingsilver94

jwinnie updated this revision to Diff 21550.Wed, May 27, 8:14 PM
jwinnie marked 3 inline comments as done.

Remove check because it fails