Page MenuHomeSolus

Update Etcher to 1.5.90
ClosedPublic

Authored by rptx on May 20 2020, 11:07 PM.

Details

Summary

Changelog:

  • Update leds behaviour

Signed-off-by: Régis Patroix <regis.patroix@gmail.com>

Test Plan
  • Flash iso on USB key

Diff Detail

Repository
R3610 etcher
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rptx created this revision.May 20 2020, 11:07 PM
rptx requested review of this revision.May 20 2020, 11:07 PM
JoshStrobl requested changes to this revision.EditedMay 21 2020, 8:09 AM
JoshStrobl added a subscriber: JoshStrobl.

This has one item in it, there's no reason we can't just provide the changelog contents directly.

This revision now requires changes to proceed.May 21 2020, 8:09 AM
rptx updated this revision to Diff 21478.May 21 2020, 8:12 AM

Update changelog

rptx updated this revision to Diff 21483.May 21 2020, 8:17 AM
rptx edited the summary of this revision. (Show Details)

Update changelog

JoshStrobl requested changes to this revision.May 21 2020, 9:23 AM

That's isn't the correct way of formatting the changelog.

  1. The "Changelog" part doesn't need to be in a list item, but rather it should be bolded.
  2. We use Markdown and single-space indentation for anything nested, so the appropriate indentation would've been - Update leds behaviour, not --

The correct changelog would be:

**Changelog:**

- Update leds behaviour
This revision now requires changes to proceed.May 21 2020, 9:23 AM
rptx updated this revision to Diff 21490.May 21 2020, 9:31 AM
rptx edited the summary of this revision. (Show Details)

Update changelog

JoshStrobl accepted this revision.May 21 2020, 9:35 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 21 2020, 9:35 AM
This revision was automatically updated to reflect the committed changes.