Page MenuHomeSolus

Update picard to 2.3.2
ClosedPublic

Authored by livingsilver94 on Wed, May 20, 8:37 PM.

Details

Summary

Fixes:

  • $firstwords function doesn't catch IndexError
  • $datetime crashes when invalid format specified
  • Have $find return "" rather than "-1" on not found
  • Deleting performer, comment or lyrics tag fails for some cases in ID3, Vorbis, MP4 and Apev2 tags
  • Host not found error when downloading PDF artwork
  • $delete(_id3:TXXX:foo) does not delete the ID3 frames
  • Deleting tag stored in ID3 TIPL frame only removes first occurrence
  • Deleting case-insensitive TXXX frames does not delete anything
  • Saving ID3 tags marked as case-insensitive causes duplicated TXXX frames
  • Crash when selecting plugin that can be updated
  • Network access is disabled error under VPN service
  • iTunes tags not removable (reappear after being deleted)
  • List index out of range when saving Vorbis file
  • Instrument EWI is rewritten "e w i"

Improvements:

  • Simplify Unicode 'Bullet' to ASCII 'Hyphen-minus'
  • Optimize format detection logic

Package changes

  • Use system UI theme
Test Plan

Successfully tagged a .flac file.

Diff Detail

Repository
R2427 picard
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Wed, May 20, 8:37 PM
livingsilver94 requested review of this revision.Wed, May 20, 8:37 PM
livingsilver94 edited the summary of this revision. (Show Details)Wed, May 20, 8:37 PM
JoshStrobl accepted this revision.Thu, May 21, 8:10 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Thu, May 21, 8:10 AM
This revision was automatically updated to reflect the committed changes.