Page MenuHomeSolus

Prevent build server from stripping debug symbols for bazel
ClosedPublic

Authored by xulongwu4 on May 18 2020, 4:21 AM.
Tags
None
Referenced Files
F11066945: D8904.diff
Fri, Aug 11, 7:01 PM
F11027299: D8904.id21493.diff
Wed, Aug 9, 3:55 AM
F10966992: D8904.id21492.diff
Thu, Jul 20, 7:11 AM
F10941556: D8904.id21494.diff
Fri, Jul 14, 6:36 AM
F10848721: D8904.id21446.diff
Jun 11 2023, 4:24 PM
F10848266: D8904.id21441.diff
Jun 11 2023, 2:11 PM
F10845884: D8904.id21494.diff
Jun 11 2023, 2:49 AM
F10843775: D8904.id21492.diff
Jun 10 2023, 7:11 PM

Details

Summary

Prevent build server from stripping debug symbols for bazel and fix bash autocompletion.

Test Plan
  1. Used bazel to build my project successfully. Resolves T8990.
  2. Verified that bash autocompletion works.

Diff Detail

Repository
R4448 bazel
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

xulongwu4 edited the test plan for this revision. (Show Details)

Weird, I managed to build a simple project with my package.yml definition. Glad you solved it!

Regarding the addition of openjdk-8-devel, that was expected, the previous release of openjdk-8 wasn't properly split.

@livingsilver94 The issue is that bazel binary is never supposed to be stripped. And when we build it locally, we don't strip it, that is why we can build projects using our locally generated eopkg file. However, the build server will automatically strip debug symbols from the binary and that will break the package. So we have to add debug: no to tell the server explicitly not to strip the debug symbols.

TL;DR: This issue only shows up when the package it built by the build server. It doesn't affect local builds and that is why we can build a local project without the debug: no line.

Fix bash autocompletion for bazel.

xulongwu4 edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
17

This is a block similar to build.

This revision now requires changes to proceed.May 21 2020, 9:05 AM

Move definitions of environment variables to the environment block.

xulongwu4 added inline comments.
package.yml
17

Now move all environment variable definitions to this block.

That doesn't resolve my marked issue of it being a step. It should be environment : |

Example: R485 package.yml:70

This revision now requires changes to proceed.May 21 2020, 10:31 AM
xulongwu4 marked an inline comment as done.

Add a pipe symbol to the environment block.

That doesn't resolve my marked issue of it being a step. It should be environment : |

Example: R485 package.yml:70

Ah I misunderstood. Should be fixed now.

No problem, thanks for the fix!

This revision is now accepted and ready to land.May 21 2020, 10:46 AM