Page MenuHomeSolus

Prevent build server from stripping debug symbols for bazel
ClosedPublic

Authored by xulongwu4 on May 18 2020, 4:21 AM.

Details

Summary

Prevent build server from stripping debug symbols for bazel and fix bash autocompletion.

Test Plan
  1. Used bazel to build my project successfully. Resolves T8990.
  2. Verified that bash autocompletion works.

Diff Detail

Repository
R4448 bazel
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xulongwu4 created this revision.May 18 2020, 4:21 AM
xulongwu4 requested review of this revision.May 18 2020, 4:21 AM
xulongwu4 edited the test plan for this revision. (Show Details)May 18 2020, 4:22 AM
xulongwu4 edited the test plan for this revision. (Show Details)
livingsilver94 added a subscriber: livingsilver94.EditedMay 18 2020, 6:56 AM

Weird, I managed to build a simple project with my package.yml definition. Glad you solved it!

Regarding the addition of openjdk-8-devel, that was expected, the previous release of openjdk-8 wasn't properly split.

@livingsilver94 The issue is that bazel binary is never supposed to be stripped. And when we build it locally, we don't strip it, that is why we can build projects using our locally generated eopkg file. However, the build server will automatically strip debug symbols from the binary and that will break the package. So we have to add debug: no to tell the server explicitly not to strip the debug symbols.

TL;DR: This issue only shows up when the package it built by the build server. It doesn't affect local builds and that is why we can build a local project without the debug: no line.

xulongwu4 updated this revision to Diff 21446.May 19 2020, 3:33 AM

Fix bash autocompletion for bazel.

xulongwu4 edited the test plan for this revision. (Show Details)May 19 2020, 3:34 AM
xulongwu4 edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.May 21 2020, 9:05 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
17

This is a block similar to build.

This revision now requires changes to proceed.May 21 2020, 9:05 AM
xulongwu4 updated this revision to Diff 21492.May 21 2020, 10:07 AM

Move definitions of environment variables to the environment block.

xulongwu4 marked an inline comment as done.May 21 2020, 10:08 AM
xulongwu4 added inline comments.
package.yml
17

Now move all environment variable definitions to this block.

JoshStrobl requested changes to this revision.May 21 2020, 10:31 AM

That doesn't resolve my marked issue of it being a step. It should be environment : |

Example: R485 package.yml:70

This revision now requires changes to proceed.May 21 2020, 10:31 AM
xulongwu4 updated this revision to Diff 21493.May 21 2020, 10:44 AM
xulongwu4 marked an inline comment as done.

Add a pipe symbol to the environment block.

That doesn't resolve my marked issue of it being a step. It should be environment : |
Example: R485 package.yml:70

Ah I misunderstood. Should be fixed now.

JoshStrobl accepted this revision.May 21 2020, 10:46 AM

No problem, thanks for the fix!

This revision is now accepted and ready to land.May 21 2020, 10:46 AM