Initial inclusion of atop, fixes T7558.
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T7558: Atop - ASCII full-screen performance monitor for Linux
Run, see that stats show.
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Needs a MAINTAINERS.md file, you can use the content below:
This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository. - Abdulkadir Furkan Şanlı - IRC: abdulocracy - Email: me@abdulocra.cy
Also, blatantly copy / pasta from Arch with little regards to Solus standards isn't acceptable at all. It takes seconds to see it's basically just a rip of https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/atop
| package.yml | ||
|---|---|---|
| 14 | You should be using install. But either way the application should be patched to use /usr/share/defaults/etc/atop instead, /etc/default isn't an acceptable path. If it is expected that the user is going to be modifying the file as well, then this needs to be further patched to be stateless and take configuration from /etc while falling back to our stateless /usr/share/defaults directory. | |
| 16 | Quotes aren't necessary and it should be 00644. Install path is incorrect as well, see note about how the application should be patched. | |
| 17 | Should be 00755. Remove quotes | |
| 18 | Quotes aren't necessary. | |
Comment Actions
I was going to maintain this at one point so I know it needs pynvml (nvidia-ml-py) run dep for nvidia stats.
From memory launch atop -> press 'e' which will inform you atopgpud service is not running and starting the service fails due to not having pynvml.
Comment Actions
I'm abandoning, doesn't seem worth the effort as it's poorly documented and getting it to work in its entirety looks to be a pain.