Page MenuHomeSolus

Update Audacity to 2.4.0
Needs RevisionPublic

Authored by rptx on May 17 2020, 3:00 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Changelog

Signed-off-by: Régis Patroix <regis.patroix@gmail.com>

Test Plan
  • Record sound and playback

Diff Detail

Repository
R403 audacity
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

rptx created this revision.May 17 2020, 3:00 PM
rptx requested review of this revision.May 17 2020, 3:00 PM
JoshStrobl requested changes to this revision.May 21 2020, 9:15 AM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.

What happened to all the plugins? Also you don't need to have the changelog as a list item when it's the only thing.

This revision now requires changes to proceed.May 21 2020, 9:15 AM
rptx added a comment.May 21 2020, 9:37 AM

What happened to all the plugins? Also you don't need to have the changelog as a list item when it's the only thing.

I'll check it out later today.

rptx added a comment.EditedMay 23 2020, 11:38 PM

What happened to all the plugins? Also you don't need to have the changelog as a list item when it's the only thing.

Here the explanation:
https://github.com/audacity/audacity/issues/530#issuecomment-632365418
Should we switch to cmake ? Or should we just copy the required plugins files?
When i try to configure using cmake, i have this error:

CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


CMake Error at CMakeLists.txt:12 (message):
  In-source builds not allowed.

  Create a new directory and run cmake from there, i.e.:

    mkdir build
    cd build
    cmake ..

  You will need to delete CMakeCache.txt and CMakeFiles from this directory
  to clean up.


-- Configuring incomplete, errors occurred!
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-setupBejdkV']' returned non-zero exit status 1
[Build] setup failed
ERRO[01:35:42] Failed to build package                       error="exit status 1"
ERRO[01:35:45] Failed to build packages

I'd say switch us to cmake. The error they provide has the obvious solution, which is:

mkdir build
cd build
%cmake ..

Build and install macros will be the same.

Any update on this?