Fixes T8978
Details
Details
- Reviewers
DataDrake - Group Reviewers
Triage Team - Maniphest Tasks
- T8978: XOW - Linux driver for the Xbox One wireless dongle
After installation, plug in the usb dongle, check if xow service is running, play some games.
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
Do you know if xow supports socket activation instead of a service? Assuming that you plug in a dongle, which then establishes a Personal Area Network BT connection to a controller, I would think that "plugging in" the dongle ought to enable the socket-activated service.
| package.yml | ||
|---|---|---|
| 17 | If you use -i $patchfile instead of < $patchfile, the command will be shown in the build log. I find that useful. YMMV. | |
Comment Actions
I'll do some research if the service could be automatically activated when a user has the usb inserted. But I would provide that solution upstream.
For v0.4 I would leave it like it is upstream.
Comment Actions
I initially removed mt76x2u blacklist from the makefile, as in my case the module doesn't bind to the dongle.
I've seen now there are dongles with different ids which the module binds to:
https://github.com/torvalds/linux/blob/master/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
Therefore the blacklist is necessary for some dongles.
| package.yml | ||
|---|---|---|
| 9 | This should be Distributable for the firmware license. | |
| 17 | I would use %apply_patches. See this example of using the macro and a series file. | |
| pspec_x86_64.xml | ||
| 28 | Should be in /usr/bin not /usr/local/bin. Make sure the configs line up with that. | |
Comment Actions
Changed to /usr/bin
Changed to %apply_patches
Changed service restart behaviour to always to have service restarted after sleep
Changed service type from idle to simple, as with binding to device idle makes no sennse in my opinion
Comment Actions
Thanks you for your input.
I made those changes.
The upstream developer reminded to look what happens after suspend, therefore I changed also the systemd service.
Comment Actions
Added upstream patch for the modprobe config file to not blacklist mt76x2u but prevent it loading for the usb dongle.
Comment Actions
If you move "fixes T8978" from the summary line to the description below, phabricator will cross-reference the Task and the Diff for you (making it nicely clickable).
Comment Actions
This revision is on hold until this upstream licensing issue is resolved: https://github.com/medusalix/xow/issues/15
Comment Actions
Hey all,
I certainly appreciate all the work put into this, however given this matter has been unresolved upstream for almost 5 months now, which IMO is more than a sufficient amount of time for the I.P. holders (MediaTek) to validate their own firmware licensing, I'm going to be closing this patch and its related task. I hope it's understandable that we cannot be put in a risky legal position by shipping the firmware associated with this project until MediaTek offers clarification and expressly gives distribution / re-distribution rights.