Page MenuHomeSolus

The inclusion of xow fixes T8978
Needs RevisionPublic

Authored by kaktuspalme on May 16 2020, 9:27 AM.

Details

Summary

Fixes T8978

Test Plan

After installation, plug in the usb dongle, check if xow service is running, play some games.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

kaktuspalme created this revision.May 16 2020, 9:27 AM
kaktuspalme requested review of this revision.May 16 2020, 9:27 AM

Update license info

Update pspec file

ermo added a subscriber: ermo.May 16 2020, 11:03 AM

Do you know if xow supports socket activation instead of a service? Assuming that you plug in a dongle, which then establishes a Personal Area Network BT connection to a controller, I would think that "plugging in" the dongle ought to enable the socket-activated service.

package.yml
17

If you use -i $patchfile instead of < $patchfile, the command will be shown in the build log.

I find that useful. YMMV.

Use patch -i as suggested

I'll do some research if the service could be automatically activated when a user has the usb inserted. But I would provide that solution upstream.
For v0.4 I would leave it like it is upstream.

kaktuspalme marked an inline comment as done.

I initially removed mt76x2u blacklist from the makefile, as in my case the module doesn't bind to the dongle.
I've seen now there are dongles with different ids which the module binds to:
https://github.com/torvalds/linux/blob/master/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c

Therefore the blacklist is necessary for some dongles.

Added udev rules to autostart service when usb dongle is plugged in

kaktuspalme edited the test plan for this revision. (Show Details)May 16 2020, 4:06 PM
DataDrake added inline comments.
package.yml
9

This should be Distributable for the firmware license.

17

I would use %apply_patches. See this example of using the macro and a series file.

pspec_x86_64.xml
28

Should be in /usr/bin not /usr/local/bin. Make sure the configs line up with that.

DataDrake requested changes to this revision.May 17 2020, 4:27 AM
This revision now requires changes to proceed.May 17 2020, 4:27 AM

Changed to /usr/bin
Changed to %apply_patches
Changed service restart behaviour to always to have service restarted after sleep
Changed service type from idle to simple, as with binding to device idle makes no sennse in my opinion

kaktuspalme marked 3 inline comments as done.May 19 2020, 2:03 PM

Thanks you for your input.
I made those changes.

The upstream developer reminded to look what happens after suspend, therefore I changed also the systemd service.

Added upstream patch for the modprobe config file to not blacklist mt76x2u but prevent it loading for the usb dongle.

algent added a subscriber: algent.May 20 2020, 1:07 PM

You forgot to edit the License from Distribution to Distributable.

Updated License

Yes, you are right. Fixed.

ermo awarded a token.May 20 2020, 2:08 PM
ermo added a comment.May 20 2020, 2:23 PM

If you move "fixes T8978" from the summary line to the description below, phabricator will cross-reference the Task and the Diff for you (making it nicely clickable).

DataDrake requested changes to this revision.May 20 2020, 3:12 PM

This revision is on hold until this upstream licensing issue is resolved: https://github.com/medusalix/xow/issues/15

This revision now requires changes to proceed.May 20 2020, 3:12 PM