Page MenuHomeSolus

Initial inclusion of navi
ClosedPublic

Authored by sethfl on May 15 2020, 8:39 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8894: Navi
Commits
R5001:97767c094e16: Initial inclusion of navi
Summary

Initial inclusion of navi.

Resolves T8894

Test Plan
  • Downloaad/manage multiple cheatsheet repos
  • Use cheatsheets for git and eopkg
  • Run commands via cheatsheets (git init, git add, eopkg up, etc)

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

sethfl created this revision.May 15 2020, 8:39 PM
sethfl requested review of this revision.May 15 2020, 8:39 PM
DataDrake requested changes to this revision.May 17 2020, 4:32 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
7

The license is Apache-2.0 not MIT.

This revision now requires changes to proceed.May 17 2020, 4:32 AM
DataDrake added inline comments.May 17 2020, 4:33 AM
pspec_x86_64.xml
31

Please use First Name Last Name.

sethfl updated this revision to Diff 21444.May 18 2020, 7:53 AM

fix license and packager name

sethfl marked 2 inline comments as done.May 18 2020, 7:54 AM
Jacek added a subscriber: Jacek.May 19 2020, 9:58 PM
JoshStrobl requested changes to this revision.May 21 2020, 9:26 AM
JoshStrobl added a subscriber: JoshStrobl.

Please include the following as a MAINTAINERS.md file, thanks!

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- Seth Flynn
  - Email: sethaflynn@gmail.com

Given I don't know if you have an IRC nick, that has been excluded. Should you have one, you can add an entry above the email one like so: - IRC: Nick

The MAINTAINERS.md file is intended to be used in the future on our solhub development platform to make automated notification of package updates and the like easier.

Patch itself looks good to me.

This revision now requires changes to proceed.May 21 2020, 9:26 AM
sethfl updated this revision to Diff 21499.May 22 2020, 1:15 PM

add a MAINTAINERS.md file

DataDrake accepted this revision.Sat, Jun 13, 5:35 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Sat, Jun 13, 5:35 PM
This revision was automatically updated to reflect the committed changes.