Build Irrlicht against system libraries (namely libjpeg, libpng, libz and libbz2) instead of bundled libs.
Details
Details
- Reviewers
DataDrake - Group Reviewers
Triage Team - Commits
- R1485:8aa221622528: Irrlicht: build against system libraries
Rebuilt minetest against this version and played Minetest Game and MineClone2 for a few minutes.
Diff Detail
Diff Detail
- Repository
- R1485 irrlicht
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Hard-coding the use of internal/vendored libraries in a header file and expecting packagers to create a patch to override this seems odious.
This ought to be configurable at build-time using a ./configure flag (or similar).
Comment Actions
@ermo, if I understood their documentation correctly, it's supposed to use system libraries just if I define those "NO_IRR_USE_NON_SYSTEM..." flags, i.e. one could just add this defines through $CFLAGS. But unfortunately, to force Irrlicht to link against external libs you also have to patch the Makefile - remove linking against static libs and add necessary flags to linker manually (see my patch), in other case it will continue to build bundled libraries and statically compile them.
And they don't provide any configuration script - just a bare Makefile.