Add component field to package.yml and update license identifier to be SPDX compliant for hyphen
ClosedPublic
Actions

Authored by akrenz on May 13 2020, 8:36 PM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Maniphest Tasks

T8747: Packages missing component

Commits

R1437:f487d8037848: Add component field to package.yml and update license identifier to be SPDX…

Test Plan

Installed the package and compiled the example.c from the source tarball, linking it against hyphen via gcc -o example example.c -l hyphen'. Afterwards running it against a file words`with the content "what is this doing at all? I do not understand" using the hyph_en_US.dic dictionary from the source tarball. Resulted in the same output as with the old Release.

Diff Detail

Repository

R1437 hyphen

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

akrenz created this revision.May 13 2020, 8:36 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 13 2020, 8:36 PM

akrenz requested review of this revision.May 13 2020, 8:36 PM

Girtablulu requested changes to this revision.May 13 2020, 8:52 PM

Girtablulu added a subscriber: Girtablulu.

Girtablulu added inline comments.

package.yml
3	needs a bump
12	should be above summary

This revision now requires changes to proceed.May 13 2020, 8:52 PM

Bump release to 2 and move component field above summary

akrenz marked 2 inline comments as done.May 13 2020, 9:09 PM

akrenz retitled this revision from Add component field to package.yml and update license identifier to be SPDX compliant to Add component field to package.yml and update license identifier to be SPDX compliant for hyphen.

Using "Fixes TNNNN" in the summary will close the Task, even if this only completes a part of it. We still expect a test plan even if nothing should have changed. It's better to test than assume.

This revision now requires changes to proceed.May 14 2020, 2:42 AM

DataDrake mentioned this in D8863: Add component and update license identifier for dcadec.May 14 2020, 2:42 AM

DataDrake mentioned this in D8862: Add component field to package.yml and update license identifier to be SPDX compliant for ctags.

DataDrake mentioned this in D8861: Add component and update license identifier for chmlib.

akrenz edited the summary of this revision. (Show Details)May 14 2020, 10:38 PM

akrenz edited the test plan for this revision. (Show Details)

Updated test Plan and removed Fix TNNNN from Summary

LGTM. Thanks!

DataDrake removed a reviewer: Girtablulu.May 17 2020, 2:46 AM

This revision is now accepted and ready to land.May 17 2020, 2:46 AM

Closed by commit R1437:f487d8037848: Add component field to package.yml and update license identifier to be SPDX… (authored by akrenz, committed by DataDrake). · Explain WhyMay 17 2020, 2:47 AM

This revision was automatically updated to reflect the committed changes.