Page MenuHomeSolus

Add component field to package.yml and update license identifier to be SPDX compliant for hyphen
ClosedPublic

Authored by akrenz on Wed, May 13, 8:36 PM.

Details

Test Plan

Installed the package and compiled the example.c from the source tarball, linking it against hyphen via gcc -o example example.c -l hyphen'. Afterwards running it against a file words`with the content "what is this doing at all? I do not understand" using the hyph_en_US.dic dictionary from the source tarball. Resulted in the same output as with the old Release.

Diff Detail

Repository
R1437 hyphen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Wed, May 13, 8:36 PM
akrenz requested review of this revision.Wed, May 13, 8:36 PM
Girtablulu requested changes to this revision.Wed, May 13, 8:52 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
3

needs a bump

12

should be above summary

This revision now requires changes to proceed.Wed, May 13, 8:52 PM
akrenz updated this revision to Diff 21335.Wed, May 13, 9:08 PM

Bump release to 2 and move component field above summary

akrenz marked 2 inline comments as done.Wed, May 13, 9:09 PM
akrenz retitled this revision from Add component field to package.yml and update license identifier to be SPDX compliant to Add component field to package.yml and update license identifier to be SPDX compliant for hyphen.
DataDrake requested changes to this revision.Thu, May 14, 2:42 AM
DataDrake added a subscriber: DataDrake.

Using "Fixes TNNNN" in the summary will close the Task, even if this only completes a part of it. We still expect a test plan even if nothing should have changed. It's better to test than assume.

This revision now requires changes to proceed.Thu, May 14, 2:42 AM
akrenz edited the summary of this revision. (Show Details)Thu, May 14, 10:38 PM
akrenz edited the test plan for this revision. (Show Details)
akrenz updated this revision to Diff 21369.Thu, May 14, 10:42 PM

Updated test Plan and removed Fix TNNNN from Summary

DataDrake accepted this revision.Sun, May 17, 2:45 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Sun, May 17, 2:46 AM