Resolves T8778
Details
Details
- Reviewers
DataDrake - Group Reviewers
Triage Team - Maniphest Tasks
- T8778: Add the HexChat theme manager
- Commits
- R1402:1912d0ce1561: Enable hexchat theme manager
- Download hexchat .hct theme files and enable them through thememan
Diff Detail
Diff Detail
- Repository
- R1402 hexchat
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| package.yml | ||
|---|---|---|
| 18 | Could just be theme-manager. Without the caret, the hexchat- prefix is automatically added. IIRC, at least. | |
| pspec_x86_64.xml | ||
|---|---|---|
| 99 | Is the .exe file needed to run thememan alone? | |
Comment Actions
So think I figured it out. It will indeed add the base packagename prefix but I was preventing it with ^
I had used budgie-extras as an example as I remember for its initial inclusion Josh saying to use ^
Which confused me as kid3 does not use ^ and that was accepted.
I assume ^ was to avoid having a package named
budgie-extras-budgie-kangaroo-applet and just have budgie-kangaroo-applet as budgie-extras = common
So in this scenario I don't need to use ^ and removed it.
*waits to be corrected by josh* :P
Comment Actions
Something worth mentioning is that my local build of the theme manager has this thing of the window created by the application has no icon whatsoever.
| package.yml | ||
|---|---|---|
| 31 | It can be mono-msbuild, the entire monodevelop is not required. They mention that you require it but it was a bad habit carried out from building packages with the Visual Studio GUI. | |
Comment Actions
Indeed, on Budgie desktop the theme manager window has no app icon in the top left of its window. I assume that is what you're referring to, not a big deal. (To be clear the panel / task bar does have an icon).
On Plasma desktop the theme manager window does have a app icon but does not have a close button. Where the close button should be there is a maximise button, after clicking that the close button appears. Annoying but not a huge deal, Plasma iso does not ship with HexChat and I imagine most Plasma users would use Konversation if they cared about theme integration.