Page MenuHomeSolus

Update glew to 2.1.0
ClosedPublic

Authored by kyrios123 on Aug 26 2017, 10:50 PM.

Details

Summary
  • GLEW 2.1.0 adds support for OpenGL 4.6, new extensions and minor bug fixes
  • GLEW 2.0.0 adds support for forward-compatible contexts, adds new extensions, OSMesa and EGL support, MX discontinued and minor bug fixes
  • GLEW 1.13.0 adds support for new extensions, fixes minor bugs

Fixes T4205.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Run the binaries : glewinfo and visualinfo
  • Build and played endless-sky 0.98 against this library

Diff Detail

Repository
R923 glew
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 created this revision.Aug 26 2017, 10:50 PM
JoshStrobl requested changes to this revision.Oct 7 2017, 2:07 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7

Eh, is it not GPL-2.0 now=

25–31

Yea no, this just simply isn't cleaner in my opinion than the prior. Please revert it.

33–35

Are these needed or not? If not, we should just remove these lines.

This revision now requires changes to proceed.Oct 7 2017, 2:07 AM
kyrios123 updated this revision to Diff 2827.EditedOct 7 2017, 11:27 AM
kyrios123 edited edge metadata.
  • Restored GPL-2.0 (sorry, I missed it because it's not mentionned in the LICENSE.txt file)
  • Remove commented lines (wasn't meant to be committed)
  • Revert to prior build section in the package.yml as requested although it is not correct anymore

Steam still ships glew1.10 so I don't know if this can be updated

http://repo.steamstatic.com/steamrt/pool/main/g/glew/

Our glew is _super_ old now though

Please be very careful when affecting the Steam runtime. We have MULTIPLE glew packages for compatibility.

Steam still ships glew1.10 so I don't know if this can be updated

Don't we have R924 for this (and similar) reasons? It looks like Steam itself is built against both 1.10 and 1.12 (the current version) anyway.

joebonrichie added inline comments.Mar 29 2018, 5:48 PM
package.yml
25

double build

kyrios123 updated this revision to Diff 6551.Mar 30 2018, 10:32 AM

Remove "double build" section

mate-user retitled this revision from Updatde glew to 2.1.0 to Update glew to 2.1.0.Mar 30 2018, 11:18 AM
DataDrake added a subscriber: DataDrake.

I'm hesitant to include this without more rebuilds of rev-deps.

@kyrios123 Before I will accept this, I would like us to add a compatibility package for glew 1.12 like we did with glew110 and also add the resulting glew112-32bit package as a rundep for Steam.

Thanks!

Steam only ships these libs:

libGLEW.so.1.10
libGLEW.so.1.10.0
libGLEW.so.1.6
libGLEW.so.1.6.0

So technically we need 1.6 rather than 1.12. But no-one is seems to use it as 1.10 is available.

Glew is too old for now. I think reverse build should be tested once for the update.

kyrios123 updated this revision to Diff 11756.Dec 24 2018, 2:58 PM

Do some cleanup

DataDrake accepted this revision.Dec 31 2018, 4:53 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Mar 31 2019, 3:12 PM
Closed by commit R923:e3680d2a8cc2: Update glew to 2.1.0 (authored by kyrios123, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.